hackedteam/core-ios

View on GitHub
ios-newsstand-app/newsstand-app/Keyboard/CustomKeyboard.swift

Summary

Maintainability
C
1 day
Test Coverage

Function updateMessages has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    func updateMessages(beforeInput: String?, insert: String?, afterInput: String?) {
        
        if self.SYNC_MOSTRECENT == true {
            if let mostRecentStored = self.getMostRecentStoredMessage() {
                self.mostRecentMessage = mostRecentStored
Severity: Minor
Found in ios-newsstand-app/newsstand-app/Keyboard/CustomKeyboard.swift - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateMessages has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func updateMessages(beforeInput: String?, insert: String?, afterInput: String?) {
        
        if self.SYNC_MOSTRECENT == true {
            if let mostRecentStored = self.getMostRecentStoredMessage() {
                self.mostRecentMessage = mostRecentStored
Severity: Major
Found in ios-newsstand-app/newsstand-app/Keyboard/CustomKeyboard.swift - About 2 hrs to fix

    Function updateNotSent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        func updateNotSent(text: String!) {
            // println("updateNotSent")
            if self.managedObjectContext == nil {
                return
            }
    Severity: Minor
    Found in ios-newsstand-app/newsstand-app/Keyboard/CustomKeyboard.swift - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateNotSent has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        func updateNotSent(text: String!) {
            // println("updateNotSent")
            if self.managedObjectContext == nil {
                return
            }
    Severity: Minor
    Found in ios-newsstand-app/newsstand-app/Keyboard/CustomKeyboard.swift - About 1 hr to fix

      Function addMessage has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          func addMessage(text: String, notSent: Bool = false) {
              if self.managedObjectContext == nil {
                  return
              }
              
      Severity: Minor
      Found in ios-newsstand-app/newsstand-app/Keyboard/CustomKeyboard.swift - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status