hackedteam/core-linux

View on GitHub
core/multilib/x86_64/usr/lib/x86_64-linux-gnu/gdbus-2.0/codegen/parser.py

Summary

Maintainability
F
1 mo
Test Coverage

Function handle_start_element has a Cognitive Complexity of 92 (exceeds 5 allowed). Consider refactoring.
Open

    def handle_start_element(self, name, attrs):
        old_state = self.state
        old_cur_object = self._cur_object
        if self.state == DBusXMLParser.STATE_IGNORED:
            self.state = DBusXMLParser.STATE_IGNORED

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handle_comment has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
Open

    def handle_comment(self, data):
        comment_state = DBusXMLParser.COMMENT_STATE_BEGIN;
        lines = data.split('\n')
        symbol = ''
        body = ''

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if len(rest_of_line) > 0:
                            body += '<para>' + rest_of_line + '</para>'
                        comment_state = DBusXMLParser.COMMENT_STATE_PARAMS

    Avoid deeply nested control flow statements.
    Open

                            if not in_para:
                                body += '<para>'
                                in_para = True
                            body += orig_line + '\n'

      Avoid deeply nested control flow statements.
      Open

                              if line.endswith(':'):
                                  symbol = line[0:len(line)-1]
                                  comment_state = DBusXMLParser.COMMENT_STATE_PARAMS
                              else:
                                  comment_state = DBusXMLParser.COMMENT_STATE_SKIP

        Avoid deeply nested control flow statements.
        Open

                                if not in_para:
                                    body += '<para>'
                                    in_para = True
                                body += orig_line + '\n'

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          core/multilib/i386/usr/lib/i386-linux-gnu/gdbus-2.0/codegen/parser.py on lines 0..290

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 2434.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status