hackedteam/fuzzer-windows

View on GitHub
fontfuzzer/fuzzers/native_glyf.py

Summary

Maintainability
F
2 wks
Test Coverage

File native_glyf.py has 334 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python

# awful
import sys
sys.path.append('../')
Severity: Minor
Found in fontfuzzer/fuzzers/native_glyf.py - About 4 hrs to fix

    Function shortName has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    def shortName(font):
    
        try:
    
            for record in font['name'].names:
    Severity: Minor
    Found in fontfuzzer/fuzzers/native_glyf.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function shortNameMine has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def shortNameMine(fontPath):
    
    
        try:
            font = TTF.TTFont(fontPath, simpleParsing=True)
    Severity: Minor
    Found in fontfuzzer/fuzzers/native_glyf.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function generateTestCases has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    def generateTestCases(fontSourceDir, dbConnection):
        fonts = {}
        testcasesFolder = 'testcases'
    
        print '[D] Generating testcases: ', os.path.abspath( fontSourceDir )
    Severity: Minor
    Found in fontfuzzer/fuzzers/native_glyf.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    def viewerDeploy(dbConnection, fuzzerRef):
    
        print '[*] Deploy fonts found in testcases folder'
        for i in os.listdir('testcases'):
            
    Severity: Major
    Found in fontfuzzer/fuzzers/native_glyf.py and 1 other location - About 4 days to fix
    fontfuzzer/fuzzers/native_ben.py on lines 319..372

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 459.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    class mainWindow():
    
        def __init__(self):
            win32gui.InitCommonControls()
            self.hinst = windll.kernel32.GetModuleHandleW(None)
    Severity: Major
    Found in fontfuzzer/fuzzers/native_glyf.py and 3 other locations - About 2 days to fix
    fontfuzzer/fuzzers/native.py on lines 58..105
    fontfuzzer/fuzzers/native_ben.py on lines 64..111
    fontfuzzer/fuzzers_downloaded/native.py on lines 51..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 307.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

    if __name__ == '__main__':
     
     
        if( len(sys.argv[1:]) < 1 ):
            print 'Usage: {} font_directory'.format(sys.argv[0])
    Severity: Major
    Found in fontfuzzer/fuzzers/native_glyf.py and 2 other locations - About 2 days to fix
    fontfuzzer/fuzzers/native.py on lines 435..468
    fontfuzzer/fuzzers/native_ben.py on lines 455..488

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 270.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if isFontFuzzed:
                    testcaseName = os.path.abspath( os.path.join( testcasesFolder,
                                                                  os.path.basename(abspath).split('.ttf')[0] + '_' +
                                                                  ''.join( random.choice( string.ascii_lowercase + string.digits) for x in range(8) ) + '.ttf')
                                                    )
    Severity: Major
    Found in fontfuzzer/fuzzers/native_glyf.py and 1 other location - About 1 day to fix
    fontfuzzer/fuzzers/native.py on lines 264..290

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 214.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    class NativeFuzzer(threading.Thread):
        
        def __init__(self, folder, queue):
            threading.Thread.__init__(self)
            self.fontsFolder = folder
    Severity: Major
    Found in fontfuzzer/fuzzers/native_glyf.py and 2 other locations - About 1 day to fix
    fontfuzzer/fuzzers/native.py on lines 387..428
    fontfuzzer/fuzzers/native_ben.py on lines 407..448

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 204.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

        try:
    
            for record in font['name'].names:
    
                if record.nameID == FONT_SPECIFIER_NAME_ID and not name:
    Severity: Major
    Found in fontfuzzer/fuzzers/native_glyf.py and 3 other locations - About 1 day to fix
    fontfuzzer/fuzzers/native.py on lines 40..51
    fontfuzzer/fuzzers/native_ben.py on lines 39..55
    fontfuzzer/fuzzers_downloaded/native.py on lines 35..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 143.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

    def draw(handleDeviceContext, char_map):
    
            chars_not_rendered = 0
            chars_rendered = 0
    
    
    Severity: Major
    Found in fontfuzzer/fuzzers/native_glyf.py and 3 other locations - About 1 day to fix
    fontfuzzer/fuzzers/native.py on lines 108..141
    fontfuzzer/fuzzers/native_ben.py on lines 114..147
    fontfuzzer/fuzzers_downloaded/native.py on lines 101..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 141.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

    def validateInputFonts(fontSourceDir):
        fonts = {}
        for i in os.listdir(sys.argv[1]):
            try:
                abspath =  os.path.abspath(sys.argv[1] + '\\' + i)
    Severity: Major
    Found in fontfuzzer/fuzzers/native_glyf.py and 3 other locations - About 1 day to fix
    fontfuzzer/fuzzers/native.py on lines 357..367
    fontfuzzer/fuzzers/native_ben.py on lines 377..387
    fontfuzzer/fuzzers_downloaded/native.py on lines 258..268

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 125.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if i.nameId == FONT_SPECIFIER_FAMILY_ID:
                    offset = name.offsetWithinFile + name.offsetToStartOfStringStorage + i.stringOffsetFromStartOfStorage
                    f.seek(offset)
                    family = unpack('>{}s'.format(i.stringLength), f.read(i.stringLength))[0]
                
    Severity: Major
    Found in fontfuzzer/fuzzers/native_glyf.py and 1 other location - About 5 hrs to fix
    fontfuzzer/fuzzers/native_glyf.py on lines 57..64

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                elif i.nameId == FONT_SPECIFIER_NAME_ID:
                    offset = name.offsetWithinFile + name.offsetToStartOfStringStorage + i.stringOffsetFromStartOfStorage
                    f.seek(offset)
                    name = unpack('>{}s'.format(i.stringLength), f.read(i.stringLength))[0]
                
    Severity: Major
    Found in fontfuzzer/fuzzers/native_glyf.py and 1 other location - About 5 hrs to fix
    fontfuzzer/fuzzers/native_glyf.py on lines 48..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

    def cleanUp():
        
        print '[*] Cleaning up fuzzed fonts'
        
        old   = 'old_testcases'
    Severity: Major
    Found in fontfuzzer/fuzzers/native_glyf.py and 2 other locations - About 2 hrs to fix
    fontfuzzer/fuzzers/native.py on lines 370..381
    fontfuzzer/fuzzers/native_ben.py on lines 390..401

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

    def deployMultiProcess(fontPath, queue):
        
        try:
            charsRendered, charsNotRendered = deploy(fontPath, ttLib.TTFont(fontPath))
            queue.put(charsRendered)
    Severity: Major
    Found in fontfuzzer/fuzzers/native_glyf.py and 2 other locations - About 2 hrs to fix
    fontfuzzer/fuzzers/native.py on lines 144..151
    fontfuzzer/fuzzers/native_ben.py on lines 150..157

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                tableToBeFuzzed = random.choice(list(set(fonts[abspath].fontTableDirectories.keys()) - set(TTF.TTFont.REQUIRED_TABLES) ))    
    Severity: Major
    Found in fontfuzzer/fuzzers/native_glyf.py and 1 other location - About 1 hr to fix
    fontfuzzer/fuzzers/native_ben.py on lines 271..271

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status