hackedteam/fuzzer-windows

View on GitHub
fontfuzzer/fuzzers_downloaded/native.py

Summary

Maintainability
F
6 days
Test Coverage

Function shortName has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

def shortName(font):
    name = ""
    family = ""

    for record in font['name'].names:
Severity: Minor
Found in fontfuzzer/fuzzers_downloaded/native.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                for i in os.listdir('testcases'):
                    m = hashlib.md5()
                    m.update(open('testcases' + '\\' + i, "rb").read())
                    print '[*]\t {} : {}'.format(i, m.hexdigest())
            
Severity: Major
Found in fontfuzzer/fuzzers_downloaded/native.py - About 45 mins to fix

    Function generateTestCases has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def generateTestCases(fontSourceDir):
        fonts = {}
    
        testcasesFolder = 'testcases'
        
    Severity: Minor
    Found in fontfuzzer/fuzzers_downloaded/native.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    class mainWindow():
    
        def __init__(self):
            win32gui.InitCommonControls()
            self.hinst = windll.kernel32.GetModuleHandleW(None)
    Severity: Major
    Found in fontfuzzer/fuzzers_downloaded/native.py and 3 other locations - About 2 days to fix
    fontfuzzer/fuzzers/native.py on lines 58..105
    fontfuzzer/fuzzers/native_ben.py on lines 64..111
    fontfuzzer/fuzzers/native_glyf.py on lines 111..158

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 307.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

        for record in font['name'].names:
            if record.nameID == FONT_SPECIFIER_NAME_ID and not name:
                if '\000' in record.string:
                    name = unicode(record.string, 'utf-16-be').encode('utf-8')
                else:
    Severity: Major
    Found in fontfuzzer/fuzzers_downloaded/native.py and 3 other locations - About 1 day to fix
    fontfuzzer/fuzzers/native.py on lines 40..51
    fontfuzzer/fuzzers/native_ben.py on lines 39..55
    fontfuzzer/fuzzers/native_glyf.py on lines 84..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 143.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

    def draw(handleDeviceContext, char_map):
    
            chars_not_rendered = 0
            chars_rendered = 0
    
    
    Severity: Major
    Found in fontfuzzer/fuzzers_downloaded/native.py and 3 other locations - About 1 day to fix
    fontfuzzer/fuzzers/native.py on lines 108..141
    fontfuzzer/fuzzers/native_ben.py on lines 114..147
    fontfuzzer/fuzzers/native_glyf.py on lines 161..194

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 141.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

    def validateInputFonts(fontSourceDir):
        fonts = {}
        for i in os.listdir(sys.argv[1]):
            try:
                abspath =  os.path.abspath(sys.argv[1] + '\\' + i)
    Severity: Major
    Found in fontfuzzer/fuzzers_downloaded/native.py and 3 other locations - About 1 day to fix
    fontfuzzer/fuzzers/native.py on lines 357..367
    fontfuzzer/fuzzers/native_ben.py on lines 377..387
    fontfuzzer/fuzzers/native_glyf.py on lines 424..434

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 125.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status