hackedteam/rcs-backdoor

View on GitHub

Showing 16 of 16 total issues

File command.rb has 310 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require_relative 'config.rb'

# RCS::Common
require 'rcs-common/trace'
require 'rcs-common/crypt'
Severity: Minor
Found in lib/rcs-backdoor/command.rb - About 3 hrs to fix

    Method run_backdoor has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

      def run_backdoor(path_to_binary, path_to_ident, options)
        b = RCS::Backdoor::Backdoor.new(path_to_binary, path_to_ident, options)
    
        # set the scout flag if specified
        b.scout = true if options[:scout]
    Severity: Minor
    Found in lib/rcs-backdoor/backdoor.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run(options)
    
        # if we can't find the trace config file, default to the system one
        if File.exist?('trace.yaml') then
          load_path = Dir.pwd
    Severity: Minor
    Found in lib/rcs-backdoor/backdoor.rb - About 1 hr to fix

      Method run! has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.run!(*argv)
          # This hash will hold all of the options parsed from the command-line by OptionParser.
          options = {}
      
          srand(Time.now.to_i)
      Severity: Minor
      Found in lib/rcs-backdoor/backdoor.rb - About 1 hr to fix

        Method authenticate_scout has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def authenticate_scout(backdoor)
            trace :info, "AUTH SCOUT"
        
            # the version of the protocol
            pver = [1].pack('I')
        Severity: Minor
        Found in lib/rcs-backdoor/command.rb - About 1 hr to fix

          Method authenticate_elite has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def authenticate_elite(backdoor)
              trace :info, "AUTH"
               
              # first part of the session key, chosen by the client
              # it will be used to derive the session key later along with Ks (server chosen)
          Severity: Minor
          Found in lib/rcs-backdoor/command.rb - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              def receive_uploads
                trace :info, "UPLOAD"
                resp = send_command(PROTO_UPLOAD)
            
                # decode the response
            Severity: Major
            Found in lib/rcs-backdoor/command.rb and 1 other location - About 1 hr to fix
            lib/rcs-backdoor/command.rb on lines 318..333

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              def receive_upgrade
                trace :info, "UPGRADE"
                resp = send_command(PROTO_UPGRADE)
            
                # decode the response
            Severity: Major
            Found in lib/rcs-backdoor/command.rb and 1 other location - About 1 hr to fix
            lib/rcs-backdoor/command.rb on lines 296..311

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method perform has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def perform(host)
            
                begin
            
                  start = Time.now
            Severity: Minor
            Found in lib/rcs-backdoor/protocol.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method initialize has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def initialize(binary_file, ident_file, options = {})
                @options = options
            
                # parse the parameters from the binary patched constants
                trace :debug, "Parsing binary data..."
            Severity: Minor
            Found in lib/rcs-backdoor/backdoor.rb - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                def receive_exec
                  trace :info, "EXEC"
                  resp = send_command(PROTO_EXEC)
              
                  # decode the response
              Severity: Major
              Found in lib/rcs-backdoor/command.rb and 1 other location - About 1 hr to fix
              lib/rcs-backdoor/command.rb on lines 340..355

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                def receive_downloads
                  trace :info, "DOWNLOAD"
                  resp = send_command(PROTO_DOWNLOAD)
                  
                  # decode the response
              Severity: Major
              Found in lib/rcs-backdoor/command.rb and 1 other location - About 1 hr to fix
              lib/rcs-backdoor/command.rb on lines 505..520

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method send_evidence has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def send_evidence(evidences)
                  
                  return if evidences.empty?
                  
                  # take the first log
              Severity: Minor
              Found in lib/rcs-backdoor/command.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def run(options)
              
                  # if we can't find the trace config file, default to the system one
                  if File.exist?('trace.yaml') then
                    load_path = Dir.pwd
              Severity: Minor
              Found in lib/rcs-backdoor/backdoor.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method authenticate_scout has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def authenticate_scout(backdoor)
                  trace :info, "AUTH SCOUT"
              
                  # the version of the protocol
                  pver = [1].pack('I')
              Severity: Minor
              Found in lib/rcs-backdoor/command.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method authenticate_elite has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def authenticate_elite(backdoor)
                  trace :info, "AUTH"
                   
                  # first part of the session key, chosen by the client
                  # it will be used to derive the session key later along with Ks (server chosen)
              Severity: Minor
              Found in lib/rcs-backdoor/command.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language