hackedteam/rcs-common

View on GitHub
lib/rcs-common/evidence/mail.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method decode_content has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def decode_content(common_info, chunks)
    info = Hash[common_info]
    info[:data] ||= Hash.new
    info[:data][:type] = :mail

Severity: Minor
Found in lib/rcs-common/evidence/mail.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method decode_additional_header has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def decode_additional_header(data)
    raise EvidenceDeserializeError.new("incomplete MAIL") if data.nil? or data.bytesize == 0

    ret = Hash.new
    ret[:data] = Hash.new
Severity: Minor
Found in lib/rcs-common/evidence/mail.rb - About 1 hr to fix

    Method decode_content has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def decode_content(common_info, chunks)
        info = Hash[common_info]
        info[:data] ||= Hash.new
        info[:data][:type] = :mail
    
    
    Severity: Minor
    Found in lib/rcs-common/evidence/mail.rb - About 1 hr to fix

      Method decode_additional_header has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def decode_additional_header(data)
          raise EvidenceDeserializeError.new("incomplete MAIL") if data.nil? or data.bytesize == 0
      
          ret = Hash.new
          ret[:data] = Hash.new
      Severity: Minor
      Found in lib/rcs-common/evidence/mail.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status