Sign upLogin

hackedteam/rcs-common

View on GitHub
Star
lib/rcs-common/serializer.rb

Summary

Maintainability
C
1 day
Test Coverage

File serializer.rb has 317 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'stringio'
require_relative 'trace'
require_relative 'evidence/common'

require 'rcs-common/trace'
Severity: Minor
Found in lib/rcs-common/serializer.rb - About 3 hrs to fix

    Method unserialize has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        def unserialize(stream)

      header_begin = stream.pos

      # discard header
    Severity: Minor
    Found in lib/rcs-common/serializer.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method unserialize has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def unserialize(stream)

      header_begin = stream.pos

      # discard header
    Severity: Minor
    Found in lib/rcs-common/serializer.rb - About 1 hr to fix

      Method unserialize has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          def unserialize(stream)
      header_begin = stream.pos

      tot_size = stream.read(4).unpack('L').shift
      version = stream.read(4).unpack('L').shift
      Severity: Minor
      Found in lib/rcs-common/serializer.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method unserialize has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def unserialize(stream)
      header_begin = stream.pos

      tot_size = stream.read(4).unpack('L').shift
      version = stream.read(4).unpack('L').shift
      Severity: Minor
      Found in lib/rcs-common/serializer.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status