Sign upLogin

hackedteam/rcs-common

View on GitHub
Star
lib/rcs-common/updater/server.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method process_http_request has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

      def process_http_request
        EM.defer do
          begin
            trace(:info, "[#{@http[:host]}] REQ #{@http_protocol} #{@http_request_method} #{@http_content.size} bytes from #{remote_addr}")
Severity: Minor
Found in lib/rcs-common/updater/server.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_http_request has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def process_http_request
        EM.defer do
          begin
            trace(:info, "[#{@http[:host]}] REQ #{@http_protocol} #{@http_request_method} #{@http_content.size} bytes from #{remote_addr}")
Severity: Minor
Found in lib/rcs-common/updater/server.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return false
    Severity: Major
    Found in lib/rcs-common/updater/server.rb - About 30 mins to fix

      Method private_ipv4? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def private_ipv4?
        a,b,c,d = remote_addr.split(".").map(&:to_i)
        return true if a==127 && b==0 && c==0 && d==1 # localhost
        return true if a==192 && b==168 && c.between?(0,255) && d.between?(0,255) # 192.168.0.0/16
        return true if a==172 && b.between?(16,31) && c.between?(0,255) && d.between?(0,255) # 172.16.0.0/12
      Severity: Minor
      Found in lib/rcs-common/updater/server.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status