Sign upLogin

hackedteam/test-av

View on GitHub
Star
analyzer/windows/lib/core/packages.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function choose_package has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def choose_package(file_type):
    """Choose analysis package due to file type.
    @param file_type: file type.
    @return: package or None.
    """
Severity: Minor
Found in analyzer/windows/lib/core/packages.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return None
Severity: Major
Found in analyzer/windows/lib/core/packages.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return "doc"
    Severity: Major
    Found in analyzer/windows/lib/core/packages.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return "xls"
      Severity: Major
      Found in analyzer/windows/lib/core/packages.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status