hackedteam/vector-applet

View on GitHub

Showing 78 of 78 total issues

Identical blocks of code found in 4 locations. Consider refactoring.
Open

package x;

import java.io.UnsupportedEncodingException;

// TODO: Provide better encoding... 
Severity: Major
Found in twostage/src-direct/x/Strings.java and 3 other locations - About 2 hrs to fix
twostage/src-exploit/x/Strings.java on lines 1..32
weaponized/src-direct/x/Strings.java on lines 1..32
weaponized/src-exploit/x/Strings.java on lines 1..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 171.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method run has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @SuppressWarnings("all")
    @Override
    public Void run() {
//        if( pJar == null ) {
//            // Default handler
Severity: Major
Found in twostage/src-exploit/x/PayloadRunnerOrig.java - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    package x;
    
    import java.io.File;
    import java.io.IOException;
    import java.io.Serializable;
    Severity: Major
    Found in twostage/src-exploit/x/EC.java and 1 other location - About 2 hrs to fix
    weaponized/src-exploit/x/EC.java on lines 1..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 154.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    package x;
    
    import java.io.File;
    import java.io.IOException;
    import java.io.Serializable;
    Severity: Major
    Found in weaponized/src-exploit/x/EC.java and 1 other location - About 2 hrs to fix
    twostage/src-exploit/x/EC.java on lines 1..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 154.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    package x;
    
    import java.io.File;
    import java.io.FileInputStream;
    import java.io.FileOutputStream;
    Severity: Major
    Found in twostage/src-datacreator/x/ClassEncryptor.java and 1 other location - About 2 hrs to fix
    weaponized/src-datacreator/x/ClassEncryptor.java on lines 1..24

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 145.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    package x;
    
    import java.io.File;
    import java.io.FileInputStream;
    import java.io.FileOutputStream;
    Severity: Major
    Found in weaponized/src-datacreator/x/ClassEncryptor.java and 1 other location - About 2 hrs to fix
    twostage/src-datacreator/x/ClassEncryptor.java on lines 1..24

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 145.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method main has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

       public static void main(String[] args) throws Exception {
            try {
                System.setSecurityManager(null);
                System.err.println("Please start with JVM parameters: -Djava.security.manager");
                System.err.println("Else running this demonstration makes no sense.");
    Severity: Minor
    Found in twostage/src-exploit/x/StandaloneStarter.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method go has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static void go() {
            if( useOldExploitOnOldJavaVersions() ) {
                return;
            }
            
    Severity: Minor
    Found in twostage/src-exploit/x/CorbaTrustedMethodChain.java - About 2 hrs to fix

      Method init has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
          public void init() {
              urlBase = getCodeBase();
      
              // Parsing arguments.
      Severity: Minor
      Found in twostage/src-exploit/x/XAppletW.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method init has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
          public void init() {
              urlBase = getCodeBase();
      
              // Parsing arguments.
      Severity: Minor
      Found in twostage/build/src-encoded/x/XAppletW.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method init has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Override
          public void init() {
              // Parsing arguments.
              EP.pClass = getParameter("pClass");  
              EP.pJar = getParameter("pJar");
      Severity: Minor
      Found in weaponized/src-exploit/x/XAppletW.java - About 1 hr to fix

        Method useOldExploitOnOldJavaVersions has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private static boolean useOldExploitOnOldJavaVersions() {
                String javaVersion = System.getProperty("java.version");
                debug("Running on "+javaVersion);
                if( javaVersion.startsWith("1.7.0_") ) {
                    if( javaVersion.compareTo("1.7.0_05") >= 0 ) {
        Severity: Minor
        Found in twostage/src-exploit/x/CorbaTrustedMethodChain.java - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public static void encodeFile(String input, String output) throws Exception {
                  byte[] bytes = new byte[128*1024]; // large enough
                  FileInputStream in = new FileInputStream(input);
                  int bytesRead = in.read(bytes);
                  in.close();
          Severity: Major
          Found in weaponized/src-datacreator/x/StringEncryptor.java and 1 other location - About 1 hr to fix
          twostage/src-datacreator/x/StringEncryptor.java on lines 28..39

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public static void encodeFile(String input, String output) throws Exception {
                  byte[] bytes = new byte[128*1024]; // large enough
                  FileInputStream in = new FileInputStream(input);
                  int bytesRead = in.read(bytes);
                  in.close();
          Severity: Major
          Found in twostage/src-datacreator/x/StringEncryptor.java and 1 other location - About 1 hr to fix
          weaponized/src-datacreator/x/StringEncryptor.java on lines 26..37

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method init has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public void init() {
                  Process f;
                  InputStream payloadStream = null;
                  
                  Properties props = new Properties();
          Severity: Minor
          Found in twostage/src-direct/Html5.java - About 1 hr to fix

            Method init has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public void init() {
                    Process f;
                    InputStream payloadStream = null;
                    
                    Properties props = new Properties();
            Severity: Minor
            Found in direct/WebEnhancer.java - About 1 hr to fix

              Method run has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  @SuppressWarnings("all")
                  @Override
                  public Void run() {
                      // System.out.println("payload");
              
              
              Severity: Minor
              Found in weaponized/src-exploit/x/PayloadRunner.java - About 1 hr to fix

                Method go has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static void go() {
                        if( useOldExploitOnOldJavaVersions() ) {
                            return;
                        }
                        
                Severity: Minor
                Found in twostage/src-exploit/x/CorbaTrustedMethodChain.java - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                    private byte[] toByteArray(InputStream is) throws IOException {
                        ByteArrayOutputStream buffer = new ByteArrayOutputStream();
                
                        int nRead;
                        byte[] data = new byte[16384];
                Severity: Major
                Found in twostage/src-exploit/x/PayloadRunner.java and 4 other locations - About 1 hr to fix
                twostage/build/src-encoded/x/XAppletW.java on lines 169..182
                twostage/src-direct/Html5.java on lines 109..122
                twostage/src-exploit/x/XAppletW.java on lines 169..182
                weaponized/src-exploit/x/PayloadRunner.java on lines 87..100

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 82.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                    private byte[] toByteArray(InputStream is) throws IOException {
                        ByteArrayOutputStream buffer = new ByteArrayOutputStream();
                
                        int nRead;
                        byte[] data = new byte[16384];
                Severity: Major
                Found in twostage/src-direct/Html5.java and 4 other locations - About 1 hr to fix
                twostage/build/src-encoded/x/XAppletW.java on lines 169..182
                twostage/src-exploit/x/PayloadRunner.java on lines 160..173
                twostage/src-exploit/x/XAppletW.java on lines 169..182
                weaponized/src-exploit/x/PayloadRunner.java on lines 87..100

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 82.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language