Sign upLogin

hackedteam/vector-exploit

View on GitHub
Star
src/ht-webkit-Android4-src/precompiled/debug/stage4.js

Summary

Maintainability
F
1 wk
Test Coverage

Function stage4 has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

function stage4(memobj, rce, libc, libwebcore, addr) {
    ENABLE_DEBUG && INFO("> [ Stage 4 ]");

    var system = libc.requiresymbol("system");
    var fopen  = libc.requiresymbol("fopen");
Severity: Minor
Found in src/ht-webkit-Android4-src/precompiled/debug/stage4.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function stage4 has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function stage4(memobj, rce, libc, libwebcore, addr) {
    ENABLE_DEBUG && INFO("> [ Stage 4 ]");

    var system = libc.requiresymbol("system");
    var fopen  = libc.requiresymbol("fopen");
Severity: Major
Found in src/ht-webkit-Android4-src/precompiled/debug/stage4.js - About 3 hrs to fix

    Function complete_stage4 has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function complete_stage4() {
    if (window['g_module'] === null) {
        ERR("Module download failed!");
    }
    Severity: Major
    Found in src/ht-webkit-Android4-src/precompiled/debug/stage4.js - About 2 hrs to fix

      Function writefile has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function writefile(filename, view) {
        memobj.writestring(cmd, filename);
        memobj.writestring(mode, "wb");
        fp = rce.call(fopen, cmd, mode);
        if (fp === 0) {
      Severity: Minor
      Found in src/ht-webkit-Android4-src/precompiled/debug/stage4.js - About 1 hr to fix

        Function stage4 has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function stage4(memobj, rce, libc, libwebcore, addr) {
        Severity: Minor
        Found in src/ht-webkit-Android4-src/precompiled/debug/stage4.js - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          function stage4(memobj, rce, libc, libwebcore, addr) {
    ENABLE_DEBUG && INFO("> [ Stage 4 ]");

    var system = libc.requiresymbol("system");
    var fopen  = libc.requiresymbol("fopen");
          Severity: Major
          Found in src/ht-webkit-Android4-src/precompiled/debug/stage4.js and 1 other location - About 1 wk to fix
          src/ht-webkit-Android4-src/src/stage4.js on lines 25..160

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 1178.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          if (window.ERR === undefined) {
    ERR = function() {
        window.location.replace("http://m.imgur.com");
    throw Error();
    };
          Severity: Minor
          Found in src/ht-webkit-Android4-src/precompiled/debug/stage4.js and 1 other location - About 45 mins to fix
          src/ht-webkit-Android4-src/src/stage4.js on lines 12..17

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status