hanami/controller

View on GitHub

Showing 3 of 3 total issues

Class Configuration has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Configuration
      # Default HTTP code for server side errors
      #
      # @since 0.2.0
      # @api private
Severity: Minor
Found in lib/hanami/controller/configuration.rb - About 2 hrs to fix

    Method finish has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def finish
            @cookies.delete(RACK_SESSION_KEY)
            @cookies.each do |k,v|
              next unless changed?(k)
              v.nil? ? delete_cookie(k) : set_cookie(k, _merge_default_values(v))
    Severity: Minor
    Found in lib/hanami/action/cookie_jar.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method extract has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def extract(env)
            hash   = env[COOKIE_HASH_KEY] ||= {}
            string = env[HTTP_HEADER]
    
            return hash if string == env[COOKIE_STRING_KEY]
    Severity: Minor
    Found in lib/hanami/action/cookie_jar.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language