Sign upLogin

heilhead/es-identifier-highlight

View on GitHub
Star
lib/inspector/handlers/literal.js

Summary

Maintainability
C
1 day
Test Coverage

Function _getLiteralUsages has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _getLiteralUsages(text) {
        let result = [];

        // ignore empty string literals
        if (typeof text === 'string' && !text.trim()) {
Severity: Major
Found in lib/inspector/handlers/literal.js - About 2 hrs to fix

    Function _getLiteralUsages has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        _getLiteralUsages(text) {
        let result = [];

        // ignore empty string literals
        if (typeof text === 'string' && !text.trim()) {
    Severity: Minor
    Found in lib/inspector/handlers/literal.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function constructor has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        constructor(inspector) {
        super(inspector);

        inspector.registerHandler([
            'Literal',
    Severity: Minor
    Found in lib/inspector/handlers/literal.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          _findUsagesByMethodDefinition(node) {
        if (node.computed) {
            return false;
        }
      Severity: Minor
      Found in lib/inspector/handlers/literal.js and 1 other location - About 55 mins to fix
      lib/inspector/handlers/literal.js on lines 74..83

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          _findUsagesByMemberExpression(node) {
        if (node.computed) {
            return false;
        }
      Severity: Minor
      Found in lib/inspector/handlers/literal.js and 1 other location - About 55 mins to fix
      lib/inspector/handlers/literal.js on lines 48..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  result.push({
                node: node.key,
                start: node.key.start,
                end: node.key.end
            });
      Severity: Minor
      Found in lib/inspector/handlers/literal.js and 2 other locations - About 35 mins to fix
      lib/inspector/handlers/literal.js on lines 130..134
      lib/inspector/handlers/literal.js on lines 160..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                      result.push({
                    node: node.property,
                    start: node.property.start,
                    end: node.property.end
                });
      Severity: Minor
      Found in lib/inspector/handlers/literal.js and 2 other locations - About 35 mins to fix
      lib/inspector/handlers/literal.js on lines 112..116
      lib/inspector/handlers/literal.js on lines 130..134

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  result.push({
                node: node.key,
                start: node.key.start,
                end: node.key.end
            });
      Severity: Minor
      Found in lib/inspector/handlers/literal.js and 2 other locations - About 35 mins to fix
      lib/inspector/handlers/literal.js on lines 112..116
      lib/inspector/handlers/literal.js on lines 160..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status