heiseonline/shariff-backend-php

View on GitHub

Showing 5 of 23 total issues

Function get has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function get(string $url)
    {
        // Changing configuration invalidates the cache
        $cacheKey = md5($url . $this->baseCacheKey);

Severity: Minor
Found in src/Backend/BackendManager.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get(string $url)
    {
        // Changing configuration invalidates the cache
        $cacheKey = md5($url . $this->baseCacheKey);

Severity: Minor
Found in src/Backend/BackendManager.php - About 1 hr to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            string $baseCacheKey,
            CacheInterface $cache,
            ClientInterface $client,
            $domains,
            array $services
    Severity: Minor
    Found in src/Backend/BackendManager.php - About 35 mins to fix

      Avoid too many return statements within this method.
      Open

              return $counts;
      Severity: Major
      Found in src/Backend/BackendManager.php - About 30 mins to fix

        Function extractCount has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function extractCount(array $data): int
            {
                $count = 0;
                if (!empty($data['data']['children'])) {
                    foreach ($data['data']['children'] as $child) {
        Severity: Minor
        Found in src/Backend/Reddit.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language