heroku/heroku-cli-addons

View on GitHub

Showing 27 of 27 total issues

Function run has 200 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function * run (ctx, api) {
  const util = require('../../lib/util')
  const table = util.table
  const style = util.style
  const formatPrice = util.formatPrice
Severity: Major
Found in commands/addons/index.js - About 1 day to fix

    Function run has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
    Open

    function * run (ctx, api) {
      const util = require('../../lib/util')
      const table = util.table
      const style = util.style
      const formatPrice = util.formatPrice
    Severity: Minor
    Found in commands/addons/index.js - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    module.exports = {
      topic: 'addons',
      command: 'open',
      wantsApp: true,
      needsAuth: true,
    Severity: Major
    Found in commands/addons/open.js and 1 other location - About 3 hrs to fix
    commands/addons/docs.js on lines 22..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    module.exports = {
      topic: 'addons',
      command: 'docs',
      wantsApp: true,
      needsAuth: true,
    Severity: Major
    Found in commands/addons/docs.js and 1 other location - About 3 hrs to fix
    commands/addons/open.js on lines 90..99

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const appAddon = function (heroku, app, id, options = {}) {
      const headers = addonHeaders()
      return heroku.post('/actions/addons/resolve', {
        'headers': headers,
        'body': {'app': app, 'addon': id, 'addon_service': options.addon_service}
    Severity: Major
    Found in lib/resolve.js and 1 other location - About 2 hrs to fix
    lib/resolve.js on lines 176..181

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const appAttachment = function (heroku, app, id, options = {}) {
      const headers = attachmentHeaders()
      return heroku.post('/actions/addon-attachments/resolve', {
        'headers': headers, 'body': {'app': app, 'addon_attachment': id, 'addon_service': options.addon_service}
      }).then(singularize('addon_attachment', options.namespace))
    Severity: Major
    Found in lib/resolve.js and 1 other location - About 2 hrs to fix
    lib/resolve.js on lines 19..26

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function displayForApp has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function displayForApp (app, addons) {
        if (addons.length === 0) {
          cli.log(`No add-ons for app ${app}.`)
          return
        }
    Severity: Major
    Found in commands/addons/index.js - About 2 hrs to fix

      Function addonGetter has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function * addonGetter (api, app) {
          let attachments, addons
      
          if (app) { // don't disploy attachments globally
            addons = api.get(`/apps/${app}/addons`, {headers: {
      Severity: Major
      Found in commands/addons/index.js - About 2 hrs to fix

        Function displayAll has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function displayAll (addons) {
            addons = sortBy(addons, 'app.name', 'plan.name', 'addon.name')
        
            if (addons.length === 0) {
              cli.log('No add-ons.')
        Severity: Minor
        Found in commands/addons/index.js - About 1 hr to fix

          Function parseConfig has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

          function parseConfig (args) {
            let config = {}
            while (args.length > 0) {
              let key = args.shift()
              if (!key.startsWith('--')) throw new Error(`Unexpected argument ${key}`)
          Severity: Minor
          Found in commands/addons/create.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function attachment has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          exports.attachment = function (heroku, app, id, options = {}) {
            const headers = attachmentHeaders()
          
            function getAttachment (id) {
              return heroku.post('/actions/addon-attachments/resolve', {
          Severity: Minor
          Found in lib/resolve.js - About 1 hr to fix

            Function run has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function * run (context, heroku) {
              const util = require('../../lib/util')
            
              let app = context.app
              let addon = yield heroku.get(`/addons/${encodeURIComponent(context.args.addon_name)}`)
            Severity: Minor
            Found in commands/addons/attach.js - About 1 hr to fix

              Function exports has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = function * (heroku, app, plan, confirm, wait, options) {
                const util = require('./util')
                const waitForAddonProvisioning = require('./addons_wait')
              
                function createAddonRequest (confirm) {
              Severity: Minor
              Found in lib/create_addon.js - About 1 hr to fix

                Function run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                function * run (context, heroku) {
                  const util = require('../../lib/util')
                
                  let app = context.app
                  let addon = yield heroku.get(`/addons/${encodeURIComponent(context.args.addon_name)}`)
                Severity: Minor
                Found in commands/addons/attach.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                function * run (ctx, api) {
                  const resolve = require('../../lib/resolve')
                
                  let addons
                  if (ctx.args.addon) {
                Severity: Minor
                Found in commands/addons/wait.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function run has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function * run (c, h) {
                  const resolver = require('../../lib/resolve')
                  const util = require('../../lib/util')
                
                  context = c
                Severity: Minor
                Found in commands/addons/upgrade.js - About 1 hr to fix

                  Function writeSudoTemplate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function writeSudoTemplate (ctx, sso, path) {
                    return new Promise(function (resolve, reject) {
                      let html = `<!DOCTYPE HTML>
                  <html>
                    <head>
                  Severity: Minor
                  Found in commands/addons/open.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        return heroku.post('/actions/addon-attachments/resolve', {
                          'headers': headers, 'body': {'app': null, 'addon_attachment': id, 'addon_service': options.addon_service}
                        }).then(singularize('addon_attachment', options.namespace))
                    Severity: Major
                    Found in lib/resolve.js and 1 other location - About 1 hr to fix
                    lib/resolve.js on lines 42..46

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 58.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        return heroku.post('/actions/addons/resolve', {
                          'headers': headers,
                          'body': {'app': null, 'addon': id, 'addon_service': options.addon_service}
                        })
                          .then(singularize('addon', options.namespace))
                    Severity: Major
                    Found in lib/resolve.js and 1 other location - About 1 hr to fix
                    lib/resolve.js on lines 125..127

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 58.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function * run (context, heroku) {
                      const resolve = require('../../lib/resolve')
                      const {groupBy, toPairs} = require('lodash')
                    
                      let force = context.flags.force || process.env.HEROKU_FORCE === '1'
                    Severity: Minor
                    Found in commands/addons/destroy.js - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language