Sign upLogin

holderdeord/hdo-site

View on GitHub
Star
app/assets/javascripts/issueEditor.js

Summary

Maintainability
D
2 days
Test Coverage

File issueEditor.js has 354 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*global jQuery, HDO, Handlebars */

(function ($, HDO, Handlebars) {
    HDO.issueEditor = {
        create: function (opts) {
Severity: Minor
Found in app/assets/javascripts/issueEditor.js - About 4 hrs to fix

    Function createCart has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            createCart: function (el) {
            var items, template, callbacks;

            items = [];
            template = this.templates['shopping-cart-template'];
    Severity: Major
    Found in app/assets/javascripts/issueEditor.js - About 2 hrs to fix

      Function facetSearch has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              facetSearch: function (opts) {
            var baseUrl, root, template, spinner, query, cart, issueId;

            baseUrl  = opts.baseUrl;
            root     = opts.root;
      Severity: Major
      Found in app/assets/javascripts/issueEditor.js - About 2 hrs to fix

        Function setupCarts has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                setupCarts: function () {
            var toggleRow, promiseTemplate, propositionTemplate;

            this.promiseCart = this.createCart($('.cart[data-type=promises]'));
            this.propositionCart = this.createCart($('.cart[data-type=propositions]'));
        Severity: Minor
        Found in app/assets/javascripts/issueEditor.js - About 2 hrs to fix

          Function init has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  init: function () {
            this.setupTemplates();
            this.renderForm();

            HDO.markdownEditor();
          Severity: Minor
          Found in app/assets/javascripts/issueEditor.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        this.facetSearch({
                baseUrl:  '/propositions',
                root:     this.propositionSearchTab,
                spinner:  this.propositionSpinner,
                template: this.templates['proposition-search-template'],
            Severity: Major
            Found in app/assets/javascripts/issueEditor.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/issueEditor.js on lines 50..57

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        this.facetSearch({
                baseUrl:  '/promises',
                root:     this.promiseSearchTab,
                spinner:  this.promiseSpinner,
                template: this.templates['promise-search-template'],
            Severity: Major
            Found in app/assets/javascripts/issueEditor.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/issueEditor.js on lines 59..66

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status