Sign upLogin

holidayextras/jsonapi-store-elasticsearch

View on GitHub
Star

Showing 5 of 8 total issues

File elasticsearchHandler.js has 251 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";
var ElasticsearchStore = module.exports = function ElasticsearchStore() { };

var async = require("async");
var debug = require("debug")("jsonApi:store:elasticsearch");
Severity: Minor
Found in lib/elasticsearchHandler.js - About 2 hrs to fix

    Function _generateMappingFor has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ElasticsearchStore.prototype._generateMappingFor = function(resourceConfig) {
  var mapping = { properties: {
    id: {
      type: "string"
    },
    Severity: Minor
    Found in lib/elasticsearchHandler.js - About 1 hr to fix

      Function _buildQuery has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      ElasticsearchStore.prototype._buildQuery = function(request) {
  var self = this;

  var queryString = "type:" + request.params.type;
  if (!request.params.filter) return queryString;
      Severity: Minor
      Found in lib/elasticsearchHandler.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function search has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      ElasticsearchStore.prototype.search = function(request, callback) {
  var self = this;
  var params = _.assign({
    index: "jsonapi",
    q: self._buildQuery(request)
      Severity: Minor
      Found in lib/elasticsearchHandler.js - About 1 hr to fix

        Function _buildQuery has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        ElasticsearchStore.prototype._buildQuery = function(request) {
  var self = this;

  var queryString = "type:" + request.params.type;
  if (!request.params.filter) return queryString;
        Severity: Minor
        Found in lib/elasticsearchHandler.js - About 1 hr to fix
          Severity
          Category
          Status
          Source
          Language