View on GitHub


1 hr
Test Coverage

Method records_for has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

            def records_for(ids, &block)
              return super unless klass.second_level_cache_enabled?
              return super unless reflection.is_a?(::ActiveRecord::Reflection::BelongsToReflection)
              return super if klass.default_scopes.present? || reflection.scope
              return super if association_key_name.to_s != klass.primary_key
Severity: Minor
Found in lib/second_level_cache/active_record/preloader/legacy.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.

              return SecondLevelCache::RecordRelation.new(record_marshals) if missed_ids.empty?
Severity: Major
Found in lib/second_level_cache/active_record/preloader/legacy.rb - About 30 mins to fix

    There are no issues that match your filters.