Showing 380 of 1,093 total issues
Method init
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function init(&$link, $controlPoints, $widths, $directions = 2, $splitPosition = 50, $arrowStyle = 'classic')
Method buildOverlibHTML
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
private function buildOverlibHTML($mapItem, $dir, $imageExtraHTML, $left, $above, $caption)
Method drawLabelRotated
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
private function drawLabelRotated($imageRef, $centre, $degreesAngle, $text, $padding, $direction)
Method drawImageString
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function drawImageString($gdImage, $x, $y, $string, $colour, $angle = 0)
Function updateMapProperties
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function updateMapProperties($params)
{
if (!$this->isLoaded()) {
throw new WeathermapInternalFail("Map must be loaded before editing API called.");
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function prepareForDataCollection
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function prepareForDataCollection()
{
/** @var Target $target */
foreach ($this->targets as $target) {
MapUtility::debug("ProcessTargets: New Target: $target\n");
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getSNMPData
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
private function getSNMPData($host, $params, $oids, &$item, $timeout, $retries)
Function getConfigInOutOrBoth
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected function getConfigInOutOrBoth($comparison, $configKeyword, $fieldName)
{
$output = '';
$myArray = $this->$fieldName;
$theirArray = $comparison->$fieldName;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function readConfigSimpleAssignment
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
private function readConfigSimpleAssignment($keyword, $matches)
{
foreach ($keyword[1] as $key => $val) {
// so we can poke in numbers too, if the value starts with #
// then take the # off, and treat the rest as a number literal
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function handleNodeStep1
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function handleNodeStep1($request, $context = null)
{
global $config; // Cacti config object
$hostId = -1;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function weathermap_show_tab
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
function weathermap_show_tab()
{
global $config, $user_auth_realm_filenames;
$realmID = 0;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if ($size[0] > $this->minBGImageSize && $size[1] > $this->minBGImageSize) {
$bg = true;
}
Function extractSettingsCookie
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function extractSettingsCookie($cookies)
{
// these are all set via the Editor Settings dialog, in the editor, now.
$this->useOverlayVIA = false; // set to TRUE to enable experimental overlay showing VIAs
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function mapReadOnlySettings
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function mapReadOnlySettings(
$id,
$title = ''
) {
if ($title == '') {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method drawLabel
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
private function drawLabel(&$map, $textPoint, $backgroundColour, $nodeImageRef, $labelBox)
Method drawMarkerPolygon
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public static function drawMarkerPolygon($gdImage, $colour, $point, $size, $relativeMoves)
Method addSpan
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function addSpan($lowValue, $highValue, $lowColour, $highColour = null, $tag = '')
Method imagecreatescaledcolourizedfromfile
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function imagecreatescaledcolourizedfromfile($filename, $scaleWidth, $scaleHeight, $colour, $colourMethod)
Method buildOverlibPositioning
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
private function buildOverlibPositioning($mapItem, $midX, $mapCenterX, $midY, $mapCenterY)
Function copyParamsFromCacti
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
private function copyParamsFromCacti($profileName, $hostId)
{
$params = array();
foreach ($this->snmpParamDefaults as $keyname => $default) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"