Sign upLogin

howardjones/network-weathermap

View on GitHub
Star
websrc/cacti-mgmt/src/services/api.js

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    disableMap(mapId) {
        const source_url = this.base_url + "disable_map";
        console.log(`API disabling map with id ${mapId} via ${source_url}`);

        const config = {headers: {'Content-Type': 'multipart/form-data', withCredentials: true}};
Severity: Major
Found in websrc/cacti-mgmt/src/services/api.js and 4 other locations - About 4 hrs to fix
websrc/cacti-mgmt/src/services/api.js on lines 29..41
websrc/cacti-mgmt/src/services/api.js on lines 44..56
websrc/cacti-mgmt/src/services/api.js on lines 74..86
websrc/cacti-mgmt/src/services/api.js on lines 88..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    addGroup(group_name) {
        const source_url = this.base_url + "group_add";
        console.log(`API Adding ${group_name} via ${source_url}`)

        const config = {headers: {'Content-Type': 'multipart/form-data', withCredentials: true}};
Severity: Major
Found in websrc/cacti-mgmt/src/services/api.js and 4 other locations - About 4 hrs to fix
websrc/cacti-mgmt/src/services/api.js on lines 44..56
websrc/cacti-mgmt/src/services/api.js on lines 74..86
websrc/cacti-mgmt/src/services/api.js on lines 88..100
websrc/cacti-mgmt/src/services/api.js on lines 102..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    removeMap(mapId) {
        const source_url = this.base_url + "delete_map";
        console.log(`API Removing map with id ${mapId} via ${source_url}`);

        const config = {headers: {'Content-Type': 'multipart/form-data', withCredentials: true}};
Severity: Major
Found in websrc/cacti-mgmt/src/services/api.js and 4 other locations - About 4 hrs to fix
websrc/cacti-mgmt/src/services/api.js on lines 29..41
websrc/cacti-mgmt/src/services/api.js on lines 44..56
websrc/cacti-mgmt/src/services/api.js on lines 88..100
websrc/cacti-mgmt/src/services/api.js on lines 102..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    enableMap(mapId) {
        const source_url = this.base_url + "enable_map";
        console.log(`API enabling map with id ${mapId} via ${source_url}`);

        const config = {headers: {'Content-Type': 'multipart/form-data', withCredentials: true}};
Severity: Major
Found in websrc/cacti-mgmt/src/services/api.js and 4 other locations - About 4 hrs to fix
websrc/cacti-mgmt/src/services/api.js on lines 29..41
websrc/cacti-mgmt/src/services/api.js on lines 44..56
websrc/cacti-mgmt/src/services/api.js on lines 74..86
websrc/cacti-mgmt/src/services/api.js on lines 102..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    removeGroup(groupId) {
        const source_url = this.base_url + "group_delete";
        console.log(`API Removing group with id ${groupId} via ${source_url}`)

        const config = {headers: {'Content-Type': 'multipart/form-data', withCredentials: true}};
Severity: Major
Found in websrc/cacti-mgmt/src/services/api.js and 4 other locations - About 4 hrs to fix
websrc/cacti-mgmt/src/services/api.js on lines 29..41
websrc/cacti-mgmt/src/services/api.js on lines 74..86
websrc/cacti-mgmt/src/services/api.js on lines 88..100
websrc/cacti-mgmt/src/services/api.js on lines 102..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status