hpi-swt2/workshop-portal

View on GitHub

Showing 494 of 494 total issues

Using width with border can sometimes make elements larger than you expect.
Open

  border: 2px solid red;
Severity: Minor
Found in app/assets/stylesheets/scaffold.css by csslint

Redundant self detected.
Open

      self.destroy
Severity: Minor
Found in app/models/agreement_letter.rb by rubocop

This cop checks for redundant uses of self.

The usage of self is only needed when:

  • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

  • Calling an attribute writer to prevent an local variable assignment.

Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

Note we allow uses of self with operators because it would be awkward otherwise.

Example:

# bad
def foo(bar)
  self.baz
end

# good
def foo(bar)
  self.bar  # Resolves name clash with the argument.
end

def foo
  bar = 1
  self.bar  # Resolves name clash with the local variable.
end

def foo
  %w[x y z].select do |bar|
    self.bar == bar  # Resolves name clash with argument of the block.
  end
end

Missing space after #.
Open

  #validate that application deadline is before the start of the event
Severity: Minor
Found in app/models/event.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Line is too long. [98/80]
Open

  # 2. All participants that have to submit an letter of agreement and did do so, ordered by name.
Severity: Minor
Found in app/models/event.rb by rubocop

Line is too long. [92/80]
Open

    application_letters.all? { |application_letter| application_letter.status != 'pending' }
Severity: Minor
Found in app/models/event.rb by rubocop

Line is too long. [100/80]
Open

    rejected_applications = application_letters.where(status: ApplicationLetter.statuses[:rejected])
Severity: Minor
Found in app/models/event.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

    if after_deadline?
Severity: Minor
Found in app/models/application_letter.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Line is too long. [83/80]
Open

      can [:index, :show, :edit, :update, :destroy], Profile, user: { id: user.id }
Severity: Minor
Found in app/models/ability.rb by rubocop

Inconsistent indentation detected.
Open

    def too_big?(file)
      file.size > MAX_SIZE
    end
Severity: Minor
Found in app/models/agreement_letter.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    @participants.sort { |x, y| self.compare_participants_by_agreement(x,y) }
Severity: Minor
Found in app/models/event.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Space missing after comma.
Open

    @participants.sort { |x, y| self.compare_participants_by_agreement(x,y) }
Severity: Minor
Found in app/models/event.rb by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Line is too long. [98/80]
Open

  # 2. All participants that have to submit an letter of agreement and did do so, ordered by name.
Severity: Minor
Found in app/models/event.rb by rubocop

Don't use parentheses around a method call.
Open

  validate :deadline_cannot_be_in_the_past, :if => Proc.new { |letter| !(letter.status_changed?) }
Severity: Minor
Found in app/models/application_letter.rb by rubocop

This cop checks for redundant parentheses.

Example:

# bad
(x) if ((y.z).nil?)

# good
x if y.z.nil?

Use %i or %I for an array of symbols.
Open

      can [:new, :create], Profile
Severity: Minor
Found in app/models/ability.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Inconsistent indentation detected.
Open

    def valid_file?(file)
      if !is_file?(file)
        errors.add(:file, I18n.t("agreement_letters.not_a_file"))
        false
      elsif too_big?(file)
Severity: Minor
Found in app/models/agreement_letter.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Redundant self detected.
Open

      self.destroy
Severity: Minor
Found in app/models/agreement_letter.rb by rubocop

This cop checks for redundant uses of self.

The usage of self is only needed when:

  • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

  • Calling an attribute writer to prevent an local variable assignment.

Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

Note we allow uses of self with operators because it would be awkward otherwise.

Example:

# bad
def foo(bar)
  self.baz
end

# good
def foo(bar)
  self.bar  # Resolves name clash with the argument.
end

def foo
  bar = 1
  self.bar  # Resolves name clash with the local variable.
end

def foo
  %w[x y z].select do |bar|
    self.bar == bar  # Resolves name clash with argument of the block.
  end
end

Line is too long. [100/80]
Open

  # @return [String] Concatenation of all email addresses of accepted applications, seperated by ','
Severity: Minor
Found in app/models/event.rb by rubocop

Line is too long. [100/80]
Open

    accepted_applications = application_letters.where(status: ApplicationLetter.statuses[:accepted])
Severity: Minor
Found in app/models/event.rb by rubocop

Space missing inside }.
Open

  validate :status_cannot_be_changed, :if => Proc.new { |letter| letter.status_changed?}
Severity: Minor
Found in app/models/application_letter.rb by rubocop

Checks that block braces have or don't have surrounding space inside them on configuration. For blocks taking parameters, it checks that the left brace has or doesn't have trailing space depending on configuration.

Example: EnforcedStyle: space (default)

# The `space` style enforces that block braces have
# surrounding space.

# bad
some_array.each {puts e}

# good
some_array.each { puts e }

Example: EnforcedStyle: no_space

# The `no_space` style enforces that block braces don't
# have surrounding space.

# bad
some_array.each { puts e }

# good
some_array.each {puts e}

Example: EnforcedStyleForEmptyBraces: no_space (default)

# The `no_space` EnforcedStyleForEmptyBraces style enforces that
# block braces don't have a space in between when empty.

# bad
some_array.each {   }
some_array.each {  }
some_array.each { }

# good
some_array.each {}

Example: EnforcedStyleForEmptyBraces: space

# The `space` EnforcedStyleForEmptyBraces style enforces that
# block braces have at least a spece in between when empty.

# bad
some_array.each {}

# good
some_array.each { }
some_array.each {  }
some_array.each {   }

Example: SpaceBeforeBlockParameters: true (default)

# The SpaceBeforeBlockParameters style set to `true` enforces that
# there is a space between `{` and `|`. Overrides `EnforcedStyle`
# if there is a conflict.

# bad
[1, 2, 3].each {|n| n * 2 }

# good
[1, 2, 3].each { |n| n * 2 }

Example: SpaceBeforeBlockParameters: true

# The SpaceBeforeBlockParameters style set to `false` enforces that
# there is no space between `{` and `|`. Overrides `EnforcedStyle`
# if there is a conflict.

# bad
[1, 2, 3].each { |n| n * 2 }

# good
[1, 2, 3].each {|n| n * 2 }

Use the new Ruby 1.9 hash syntax.
Open

  validate :status_cannot_be_changed, :if => Proc.new { |letter| letter.status_changed?}
Severity: Minor
Found in app/models/application_letter.rb by rubocop

This cop checks hash literal syntax.

It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

A separate offense is registered for each problematic pair.

The supported styles are:

  • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
  • hash_rockets - forces use of hash rockets for all hashes
  • nomixedkeys - simply checks for hashes with mixed syntaxes
  • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

Example: EnforcedStyle: ruby19 (default)

# bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

Example: EnforcedStyle: hash_rockets

# bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

Example: EnforcedStyle: nomixedkeys

# bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

Example: EnforcedStyle: ruby19nomixed_keys

# bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}
Severity
Category
Status
Source
Language