Sign upLogin

hybridgroup/cylon-firmata

View on GitHub
Star

Showing 3 of 41 total issues

Function work has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  work: function(my) {
    my.bmp180.getTemperature(function(err, val) {
      if (err) {
        console.log(err);
        return;
Severity: Minor
Found in examples/bmp180/bmp180.js - About 1 hr to fix

    Function work has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      work: function(my) {
    my.bmp180.getTemperature(function(err, val) {
      if (err) {
        console.log(err);
        return;
    Severity: Minor
    Found in examples/bmp180/bmp180.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sendOneWireWriteAndRead has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      function(pin, device, data, numBytesToRead, callback) {
    Severity: Minor
    Found in lib/firmata.js - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language