i-hardy/side-scroller

View on GitHub

Showing 21 of 23 total issues

Function exports has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(grunt) {
  grunt.initConfig({
          meta: {
              package: grunt.file.readJSON('package.json'),
              src: {
Severity: Minor
Found in Gruntfile.js - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    WorldBuilder.prototype.buildCompleteWorld = function () {
      this.buildPlatforms();
      this.createWorldBodies();
      this.nonPlatformBodies();
      this.endGamePlatform();
    Severity: Major
    Found in src/worldBuilder.js and 2 other locations - About 1 hr to fix
    src/gameController.js on lines 74..79
    src/renderer.js on lines 132..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    GameController.prototype.ready = function () {
      this.collisionEvents();
      this.buildWorld();
      this.addGround();
      this.addPlayer();
    Severity: Major
    Found in src/gameController.js and 2 other locations - About 1 hr to fix
    src/renderer.js on lines 132..137
    src/worldBuilder.js on lines 9..14

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    Renderer.prototype.gameLoop = function () {
      this.playerMovement();
      this.checkBorder();
      this.sounds();
      this.scroll();
    Severity: Major
    Found in src/renderer.js and 2 other locations - About 1 hr to fix
    src/gameController.js on lines 74..79
    src/worldBuilder.js on lines 9..14

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    SoundBank.prototype.setPlayerVols = function () {
      this._setMeowVol();
      this._setScamperVol();
      this._setThemeVol();
    };
    Severity: Minor
    Found in src/soundBank.js and 1 other location - About 45 mins to fix
    src/playerSounds.js on lines 12..16

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    PlayerSounds.prototype.loadPlayerSounds = function () {
      this._playerRunning();
      this._playerJumping();
      this._startTheme();
    };
    Severity: Minor
    Found in src/playerSounds.js and 1 other location - About 45 mins to fix
    src/soundBank.js on lines 14..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    SoundEngine.prototype._setVols = function() {
      this.playerSounds.setPlayerVols();
      this.objectSounds.setObjectVols();
    };
    Severity: Minor
    Found in src/SoundEngine.js and 1 other location - About 40 mins to fix
    src/SoundEngine.js on lines 14..17

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    SoundEngine.prototype.killSounds = function () {
      this.playerSounds.killPlayerSounds();
      this.objectSounds.killObjectSounds();
    };
    Severity: Minor
    Found in src/SoundEngine.js and 1 other location - About 40 mins to fix
    src/SoundEngine.js on lines 19..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Don't use IDs in selectors.
    Open

    #player_name_form {
    Severity: Minor
    Found in assets/styles/stylesheet.css by csslint

    Rule doesn't have all its properties in alphabetical order.
    Open

    #player_name_form input {
    Severity: Minor
    Found in assets/styles/stylesheet.css by csslint

    Rule doesn't have all its properties in alphabetical order.
    Open

    canvas {
    Severity: Minor
    Found in assets/styles/stylesheet.css by csslint

    Rule doesn't have all its properties in alphabetical order.
    Open

    .footer a {
    Severity: Minor
    Found in assets/styles/stylesheet.css by csslint

    Don't use IDs in selectors.
    Open

    #reset_game:hover {
    Severity: Minor
    Found in assets/styles/stylesheet.css by csslint

    Rule doesn't have all its properties in alphabetical order.
    Open

    .footer {
    Severity: Minor
    Found in assets/styles/stylesheet.css by csslint

    Don't use IDs in selectors.
    Open

    #submit_player_name {
    Severity: Minor
    Found in assets/styles/stylesheet.css by csslint

    Rule doesn't have all its properties in alphabetical order.
    Open

    #submit_player_name {
    Severity: Minor
    Found in assets/styles/stylesheet.css by csslint

    Don't use IDs in selectors.
    Open

    #player_name_form input {
    Severity: Minor
    Found in assets/styles/stylesheet.css by csslint

    Don't use IDs in selectors.
    Open

    #submit_player_name:hover {
    Severity: Minor
    Found in assets/styles/stylesheet.css by csslint

    Don't use IDs in selectors.
    Open

    #reset_game {
    Severity: Minor
    Found in assets/styles/stylesheet.css by csslint

    Rule doesn't have all its properties in alphabetical order.
    Open

    #reset_game {
    Severity: Minor
    Found in assets/styles/stylesheet.css by csslint
    Severity
    Category
    Status
    Source
    Language