Sign upLogin

iamisti/mdDataTable

View on GitHub
Star
app/modules/main/directives/mdtTableDirective.js

Summary

Maintainability
C
1 day
Test Coverage

Function mdtTableDirective has 122 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function mdtTableDirective(TableDataStorageFactory,
                               EditCellFeature,
                               SelectableRowsFeature,
                               PaginationFeature,
                               ColumnSelectorFeature,
Severity: Major
Found in app/modules/main/directives/mdtTableDirective.js - About 4 hrs to fix

    Function mdtTable has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                controller: function mdtTable($scope){
                var vm = this;

                $scope.rippleEffectCallback = function(){
                    return $scope.rippleEffect ? $scope.rippleEffect : false;
    Severity: Minor
    Found in app/modules/main/directives/mdtTableDirective.js - About 2 hrs to fix

      Function link has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  link: function($scope, element, attrs, ctrl, transclude){
                $scope.dataStorage = ctrl.dataStorage;

                _injectContentIntoTemplate();
      Severity: Minor
      Found in app/modules/main/directives/mdtTableDirective.js - About 1 hr to fix

        Function _injectContentIntoTemplate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        function _injectContentIntoTemplate(){
                    transclude(function (clone) {
                        var headings = [];
                        var body = [];
                        var customCell = [];
        Severity: Minor
        Found in app/modules/main/directives/mdtTableDirective.js - About 1 hr to fix

          Function mdtTableDirective has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              function mdtTableDirective(TableDataStorageFactory,
                               EditCellFeature,
                               SelectableRowsFeature,
                               PaginationFeature,
                               ColumnSelectorFeature,
          Severity: Minor
          Found in app/modules/main/directives/mdtTableDirective.js - About 45 mins to fix

            Function link has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                        link: function($scope, element, attrs, ctrl, transclude){
            Severity: Minor
            Found in app/modules/main/directives/mdtTableDirective.js - About 35 mins to fix

              TODO found
              Open

                                  //TODO: make it possible to only register feature if there is at least
              Severity: Minor
              Found in app/modules/main/directives/mdtTableDirective.js by fixme

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                          columnValues.push({
                                attributes: {
                                    editableField: false
                                },
                                rowId: rowId,
              Severity: Minor
              Found in app/modules/main/directives/mdtTableDirective.js and 1 other location - About 35 mins to fix
              app/modules/main/factories/mdtAjaxPaginationHelperFactory.js on lines 143..150

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status