Sign upLogin

iamthechad/sslinfo

View on GitHub
Star

Showing 69 of 72 total issues

File cipher.js has 323 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var tls = require('tls'),
  Q = require('q'),
  _ = require('lodash'),
  method = require('./method');
Severity: Minor
Found in lib/cipher.js - About 3 hrs to fix

    Function _trySSLMethod has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function _trySSLMethod(options) {
  var fullOptions = {
    rejectUnauthorized: false,
    secureProtocol: options.protocol.name
  };
    Severity: Minor
    Found in lib/method.js - About 2 hrs to fix

      Function trySSLCipher has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function trySSLCipher(options) {
  var deferred = Q.defer();

  var fullOptions = {
    rejectUnauthorized: false
      Severity: Minor
      Found in lib/cipher.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (msg.indexOf('methods disabled') !== -1) {
      deferred.resolve({
        protocol: options.protocol.name,
        name: options.protocol.commonName,
        enabled: false,
        Severity: Major
        Found in lib/method.js and 1 other location - About 1 hr to fix
        lib/method.js on lines 88..103

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (msg.indexOf('no ciphers available') !== -1) {
          deferred.resolve({
            protocol: options.protocol.name,
            name: options.protocol.commonName,
            enabled: false,
        Severity: Major
        Found in lib/method.js and 1 other location - About 1 hr to fix
        lib/method.js on lines 109..118

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function getCipherResults has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          getCipherResults: function(hostData) {
    var allTasks = [];
    hostData.protocols.forEach(function(item) {
      if (item.enabled) {
        var tasks = getCiphersSuitesForProtocol(item.protocol).map(function(d) {
        Severity: Minor
        Found in lib/cipher.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                deferred.reject({
        host: options.host,
        port: options.port,
        protocol: options.secureProtocol,
        protocolCommonName: options.protocolCommonName,
          Severity: Minor
          Found in lib/cipher.js and 1 other location - About 55 mins to fix
          lib/cipher.js on lines 17..24

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    return trySSLCipher({
            host: hostData.host,
            port: hostData.port,
            servername: hostData.servername,
            secureProtocol: item.protocol,
          Severity: Minor
          Found in lib/cipher.js and 1 other location - About 55 mins to fix
          lib/cipher.js on lines 109..116

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else if (msg.indexOf('SSL3_GET_RECORD:wrong version number' !== -1)) {
          deferred.resolve({
            protocol: options.protocol.name,
            name: options.protocol.commonName,
            enabled: false
          Severity: Minor
          Found in lib/method.js and 1 other location - About 35 mins to fix
          lib/method.js on lines 84..104

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                if (error.code && error.code === 'ECONNRESET') {
        deferred.resolve({protocol: options.protocol.name, name: options.protocol.commonName, enabled: false});
      } else {
        var msg = error.toString();
        if (msg.indexOf('no ciphers available') !== -1) {
          Severity: Minor
          Found in lib/method.js and 1 other location - About 35 mins to fix
          lib/method.js on lines 95..103

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Unordered list indentation
          Open

              * Use the present tense ("Add feature" not "Added feature")
          Severity: Info
          Found in CONTRIBUTING.md by markdownlint

          MD007 - Unordered list indentation

          Tags: bullet, ul, indentation

          Aliases: ul-indent

          Parameters: indent (number; default 2)

          This rule is triggered when list items are not indented by the configured number of spaces (default: 2).

          Example:

          * List item
   * Nested list item indented by 3 spaces

          Corrected Example:

          * List item
  * Nested list item indented by 2 spaces

          Rationale (2 space indent): indenting by 2 spaces allows the content of a nested list to be in line with the start of the content of the parent list when a single space is used after the list marker.

          Rationale (4 space indent): Same indent as code blocks, simpler for editors to implement. See http://www.cirosantilli.com/markdown-styleguide/#indented-lists for more information.

          In addition, this is a compatibility issue with multi-markdown parsers, which require a 4 space indents. See http://support.markedapp.com/discussions/problems/21-sub-lists-not-indenting for a description of the problem.

          Line length
          Open

           * **How does this change help others?** Most likely the answer to this question is the same way the change helped you.
          Severity: Info
          Found in CONTRIBUTING.md by markdownlint

          MD013 - Line length

          Tags: line_length

          Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)

          This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.

          This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.

          You also have the option to exclude this rule for code blocks and tables. To do this, set the code_blocks and/or tables parameters to false.

          Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.

          Code block style
          Open

              var sslinfo = require('sslinfo');
          Severity: Info
          Found in README.md by markdownlint

          Line length
          Open

          The `getServerResults()` function returns a promise that should be resolved by implementing `done()`.
          Severity: Info
          Found in README.md by markdownlint

          MD013 - Line length

          Tags: line_length

          Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)

          This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.

          This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.

          You also have the option to exclude this rule for code blocks and tables. To do this, set the code_blocks and/or tables parameters to false.

          Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.

          Line length
          Open

          The `getCertificateInfo()` function returns a promise that should be resolved by implementing `done()`.
          Severity: Info
          Found in README.md by markdownlint

          MD013 - Line length

          Tags: line_length

          Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)

          This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.

          This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.

          You also have the option to exclude this rule for code blocks and tables. To do this, set the code_blocks and/or tables parameters to false.

          Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.

          Headers should be surrounded by blank lines
          Open

          ## [0.1.6](https://github.com/iamthechad/sslinfo/tree/0.1.6) (2015-11-21)
          Severity: Info
          Found in CHANGELOG.md by markdownlint

          MD022 - Headers should be surrounded by blank lines

          Tags: headers, blank_lines

          Aliases: blanks-around-headers

          This rule is triggered when headers (any style) are either not preceded or not followed by a blank line:

          # Header 1
Some text

Some more text
## Header 2

          To fix this, ensure that all headers have a blank line both before and after (except where the header is at the beginning or end of the document):

          # Header 1

Some text

Some more text

## Header 2

          Rationale: Aside from aesthetic reasons, some parsers, including kramdown, will not parse headers that don't have a blank line before, and will parse them as regular text.

          Trailing spaces
          Open
          Severity: Info
          Found in CONTRIBUTING.md by markdownlint

          MD009 - Trailing spaces

          Tags: whitespace

          Aliases: no-trailing-spaces

          Parameters: br_spaces (number; default: 0)

          This rule is triggered on any lines that end with whitespace. To fix this, find the line that is triggered and remove any trailing spaces from the end.

          The brspaces parameter allows an exception to this rule for a specific amount of trailing spaces used to insert an explicit line break/br element. For example, set brspaces to 2 to allow exactly 2 spaces at the end of a line.

          Note: you have to set brspaces to 2 or higher for this exception to take effect - you can't insert a br element with just a single trailing space, so if you set brspaces to 1, the exception will be disabled, just as if it was set to the default of 0.

          Trailing spaces
          Open
          Severity: Info
          Found in CONTRIBUTING.md by markdownlint

          MD009 - Trailing spaces

          Tags: whitespace

          Aliases: no-trailing-spaces

          Parameters: br_spaces (number; default: 0)

          This rule is triggered on any lines that end with whitespace. To fix this, find the line that is triggered and remove any trailing spaces from the end.

          The brspaces parameter allows an exception to this rule for a specific amount of trailing spaces used to insert an explicit line break/br element. For example, set brspaces to 2 to allow exactly 2 spaces at the end of a line.

          Note: you have to set brspaces to 2 or higher for this exception to take effect - you can't insert a br element with just a single trailing space, so if you set brspaces to 1, the exception will be disabled, just as if it was set to the default of 0.

          Trailing spaces
          Open

              * Make sure that commits have descriptive text that clearly explains the change
          Severity: Info
          Found in CONTRIBUTING.md by markdownlint

          MD009 - Trailing spaces

          Tags: whitespace

          Aliases: no-trailing-spaces

          Parameters: br_spaces (number; default: 0)

          This rule is triggered on any lines that end with whitespace. To fix this, find the line that is triggered and remove any trailing spaces from the end.

          The brspaces parameter allows an exception to this rule for a specific amount of trailing spaces used to insert an explicit line break/br element. For example, set brspaces to 2 to allow exactly 2 spaces at the end of a line.

          Note: you have to set brspaces to 2 or higher for this exception to take effect - you can't insert a br element with just a single trailing space, so if you set brspaces to 1, the exception will be disabled, just as if it was set to the default of 0.

          Line length
          Open

          * Opening an issue begins a conversation. Many of the particulars can be worked out before a PR is even submitted.
          Severity: Info
          Found in CONTRIBUTING.md by markdownlint

          MD013 - Line length

          Tags: line_length

          Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)

          This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.

          This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.

          You also have the option to exclude this rule for code blocks and tables. To do this, set the code_blocks and/or tables parameters to false.

          Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.

          Severity
          Category
          Status
          Source
          Language