icyleaf/xiaomi-push

View on GitHub

Showing 3 of 3 total issues

Method to_params has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        def to_params
          hash_data = {}
          instance_variables.each do |ivar|
            key = instance_key(ivar)

Severity: Minor
Found in lib/xiaomi/push/services/messages/base.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method request_params has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        def request_params(type, messages)
          raise RequestError, '消息必须是数组类型' unless messages.kind_of?(Array)

          messages.each_with_object([]) do |message, obj|
            message = options[:message].to_params if message.kind_of?(Xiaomi::Push::Message::Base)
Severity: Minor
Found in lib/xiaomi/push/services/messages.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method send has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def send(**options)
          type, value = fetch_message_type(options)
          if type && value
            url = @context.build_uri("message/#{type[:uri]}")
            if options[:message].kind_of?Xiaomi::Push::Message::Base
Severity: Minor
Found in lib/xiaomi/push/services/message.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language