idimensionz/xarf

View on GitHub

Showing 6 of 6 total issues

XarfAbstract has 31 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class XarfAbstract implements \JsonSerializable
{
    const XARF_VERSION = '0.2';

    const XARF_CATEGORY_ABUSE = 'abuse';
Severity: Minor
Found in lib/iDimensionz/Xarf/XarfAbstract.php - About 3 hrs to fix

    Missing class import via use statement (line '244', column '23').
    Open

                throw new \InvalidArgumentException('Invalid Source Type provided');
    Severity: Minor
    Found in lib/iDimensionz/Xarf/XarfAbstract.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '127', column '23').
    Open

                throw new \InvalidArgumentException('Invalid destination type supplied');

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '140', column '23').
    Open

                throw new \InvalidArgumentException('Attachment must be none or text\plain');

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '143', column '23').
    Open

                throw new \InvalidArgumentException('Invalid category supplied');
    Severity: Minor
    Found in lib/iDimensionz/Xarf/XarfAbstract.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'setReportId'.
    Open

            $uuid = Uuid::uuid3(Uuid::NAMESPACE_DNS, $topLevelDomain);
    Severity: Minor
    Found in lib/iDimensionz/Xarf/XarfAbstract.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Severity
    Category
    Status
    Source
    Language