Sign upLogin

idlesign/django-sitegate

View on GitHub
Star
sitegate/views.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function remote_auth has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def remote_auth(request: HttpRequest, alias: str) -> HttpResponse:
    """Performs an authorization using data from a remote.
    
    For a user which is anonymous or not yet linked to target remote.
Severity: Minor
Found in sitegate/views.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return remote.auth_finish(
Severity: Major
Found in sitegate/views.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return remote.redirect()
    Severity: Major
    Found in sitegate/views.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return remote.auth_continue(request)
      Severity: Major
      Found in sitegate/views.py - About 30 mins to fix

        Function remote_auth_start has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def remote_auth_start(request: HttpRequest, alias: str) -> HttpResponse:
    """Performs a redirect to another service for remote auth.

    :param request:
    :param alias: remote service alias
        Severity: Minor
        Found in sitegate/views.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status