Sign upLogin

ifad/colore-client

View on GitHub
Star

Showing 3 of 3 total issues

Method send_request has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def send_request type, path, params={}, expect=:binary
      url = URI.join(@base_uri, path).to_s
      logger.debug( "Send #{type}: #{url}" )
      logger.debug( "  params: #{params.inspect}" )
      response = nil
Severity: Minor
Found in lib/colore/client.rb - About 1 hr to fix

    Method send_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def send_request type, path, params={}, expect=:binary
      url = URI.join(@base_uri, path).to_s
      logger.debug( "Send #{type}: #{url}" )
      logger.debug( "  params: #{params.inspect}" )
      response = nil
    Severity: Minor
    Found in lib/colore/client.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update_document has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def update_document( doc_id:, filename:, content: nil, author: nil, actions:nil, callback_url:nil )
      params = {}
      params[:actions] = actions if actions
      params[:author] = author if author
      params[:callback_url] = callback_url if callback_url
    Severity: Minor
    Found in lib/colore/client.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language