igor-alexandrov/wiselinks

View on GitHub

Showing 73 of 73 total issues

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    Response.prototype._extract_title = function() {
      if (this._is_full_document_response()) {
        return $('title', this._get_doc()).text();
      } else {
        return this.xhr.getResponseHeader('X-Wiselinks-Title');
Severity: Major
Found in build/wiselinks-1.2.2.js and 5 other locations - About 2 hrs to fix
build/wiselinks-1.2.2.js on lines 534..540
build/wiselinks-1.2.2.js on lines 546..552
build/wiselinks-1.2.2.js on lines 558..564
build/wiselinks-1.2.2.js on lines 570..576
build/wiselinks-1.2.2.js on lines 582..588

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    Response.prototype._extract_canonical = function() {
      if (this._is_full_document_response()) {
        return $('link[rel="canonical"]', this._get_doc()).text();
      } else {
        return this.xhr.getResponseHeader('X-Wiselinks-Canonical');
Severity: Major
Found in build/wiselinks-1.2.2.js and 5 other locations - About 2 hrs to fix
build/wiselinks-1.2.2.js on lines 522..528
build/wiselinks-1.2.2.js on lines 534..540
build/wiselinks-1.2.2.js on lines 558..564
build/wiselinks-1.2.2.js on lines 570..576
build/wiselinks-1.2.2.js on lines 582..588

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    Response.prototype._extract_link_rel_next = function() {
      if (this._is_full_document_response()) {
        return $('link[rel="next"]', this._get_doc()).text();
      } else {
        return this.xhr.getResponseHeader('X-Wiselinks-LinkRelNext');
Severity: Major
Found in build/wiselinks-1.2.2.js and 5 other locations - About 2 hrs to fix
build/wiselinks-1.2.2.js on lines 522..528
build/wiselinks-1.2.2.js on lines 534..540
build/wiselinks-1.2.2.js on lines 546..552
build/wiselinks-1.2.2.js on lines 558..564
build/wiselinks-1.2.2.js on lines 570..576

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    Response.prototype._extract_robots = function() {
      if (this._is_full_document_response()) {
        return $('meta[name="robots"]', this._get_doc()).text();
      } else {
        return this.xhr.getResponseHeader('X-Wiselinks-Robots');
Severity: Major
Found in build/wiselinks-1.2.2.js and 5 other locations - About 2 hrs to fix
build/wiselinks-1.2.2.js on lines 522..528
build/wiselinks-1.2.2.js on lines 534..540
build/wiselinks-1.2.2.js on lines 546..552
build/wiselinks-1.2.2.js on lines 570..576
build/wiselinks-1.2.2.js on lines 582..588

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    RequestManager.prototype._description = function(value) {
      if (value != null) {
        $(document).trigger('page:description', decodeURI(value));
        return $('meta[name="description"]').attr('content', decodeURI(value));
      }
Severity: Major
Found in build/wiselinks-1.2.2.js and 4 other locations - About 1 hr to fix
build/wiselinks-1.2.2.js on lines 451..456
build/wiselinks-1.2.2.js on lines 458..463
build/wiselinks-1.2.2.js on lines 465..470
build/wiselinks-1.2.2.js on lines 472..477

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    RequestManager.prototype._robots = function(value) {
      if (value != null) {
        $(document).trigger('page:robots', decodeURI(value));
        return $('meta[name="robots"]').attr('content', decodeURI(value));
      }
Severity: Major
Found in build/wiselinks-1.2.2.js and 4 other locations - About 1 hr to fix
build/wiselinks-1.2.2.js on lines 444..449
build/wiselinks-1.2.2.js on lines 451..456
build/wiselinks-1.2.2.js on lines 465..470
build/wiselinks-1.2.2.js on lines 472..477

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    RequestManager.prototype._canonical = function(value) {
      if (value != null) {
        $(document).trigger('page:canonical', decodeURI(value));
        return $('link[rel="canonical"]').attr('href', decodeURI(value));
      }
Severity: Major
Found in build/wiselinks-1.2.2.js and 4 other locations - About 1 hr to fix
build/wiselinks-1.2.2.js on lines 444..449
build/wiselinks-1.2.2.js on lines 458..463
build/wiselinks-1.2.2.js on lines 465..470
build/wiselinks-1.2.2.js on lines 472..477

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    RequestManager.prototype._link_rel_next = function(value) {
      if (value != null) {
        $(document).trigger('page:link_rel_next', decodeURI(value));
        return $('link[rel="next"]').attr('href', decodeURI(value));
      }
Severity: Major
Found in build/wiselinks-1.2.2.js and 4 other locations - About 1 hr to fix
build/wiselinks-1.2.2.js on lines 444..449
build/wiselinks-1.2.2.js on lines 451..456
build/wiselinks-1.2.2.js on lines 458..463
build/wiselinks-1.2.2.js on lines 465..470

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    RequestManager.prototype._link_rel_prev = function(value) {
      if (value != null) {
        $(document).trigger('page:link_rel_prev', decodeURI(value));
        return $('link[rel="prev"]').attr('href', decodeURI(value));
      }
Severity: Major
Found in build/wiselinks-1.2.2.js and 4 other locations - About 1 hr to fix
build/wiselinks-1.2.2.js on lines 444..449
build/wiselinks-1.2.2.js on lines 451..456
build/wiselinks-1.2.2.js on lines 458..463
build/wiselinks-1.2.2.js on lines 472..477

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function onUnload has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            History.onUnload = function(){
                // Prepare
                var    currentStore, item, currentStoreString;

                // Fetch
Severity: Minor
Found in build/wiselinks-1.2.2.js - About 1 hr to fix

    Function onUnload has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                History.onUnload = function(){
                    // Prepare
                    var    currentStore, item, currentStoreString;
    
                    // Fetch
    Severity: Minor
    Found in lib/assets/javascripts/lib/native.history.js - About 1 hr to fix

      Function log has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              History.log = function(){
                  // Prepare
                  var
                      consoleExists = !(typeof console === 'undefined' || typeof console.log === 'undefined' || typeof console.log.apply === 'undefined'),
                      textarea = document.getElementById('log'),
      Severity: Minor
      Found in build/wiselinks-1.2.2.js - About 1 hr to fix

        Function log has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                History.log = function(){
                    // Prepare
                    var
                        consoleExists = !(typeof console === 'undefined' || typeof console.log === 'undefined' || typeof console.log.apply === 'undefined'),
                        textarea = document.getElementById('log'),
        Severity: Minor
        Found in lib/assets/javascripts/lib/native.history.js - About 1 hr to fix

          Function onPopState has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      History.onPopState = function(event,extra){
                          // Prepare
                          var stateId = false, newState = false, currentHash, currentState;
          
                          // Reset the double check
          Severity: Minor
          Found in build/wiselinks-1.2.2.js - About 1 hr to fix

            Function onPopState has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                        History.onPopState = function(event,extra){
                            // Prepare
                            var stateId = false, newState = false, currentHash, currentState;
            
                            // Reset the double check
            Severity: Minor
            Found in lib/assets/javascripts/lib/native.history.js - About 1 hr to fix

              Function Page has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function Page($target, options) {
                    var self;
                    this.$target = $target;
                    this.options = options;
                    self = this;
              Severity: Minor
              Found in build/wiselinks-1.2.2.js - About 1 hr to fix

                Function pushState has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                            History.pushState = function(data,title,url,queue){
                                //History.debug('History.pushState: called', arguments);
                
                                // We assume that the URL passed in is URI-encoded, but this makes
                                // sure that it's fully URI encoded; any '%'s that are encoded are
                Severity: Minor
                Found in build/wiselinks-1.2.2.js - About 1 hr to fix

                  Function pushState has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                              History.pushState = function(data,title,url,queue){
                                  //History.debug('History.pushState: called', arguments);
                  
                                  // We assume that the URL passed in is URI-encoded, but this makes
                                  // sure that it's fully URI encoded; any '%'s that are encoded are
                  Severity: Minor
                  Found in lib/assets/javascripts/lib/native.history.js - About 1 hr to fix

                    Function parse has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            JSON.parse = function (text, reviver) {
                    
                    // The parse method takes a text and an optional reviver function, and returns
                    // a JavaScript value if the text is a valid JSON text.
                    
                    
                    Severity: Minor
                    Found in build/wiselinks-1.2.2.js - About 1 hr to fix

                      Function parse has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              JSON.parse = function (text, reviver) {
                      
                      // The parse method takes a text and an optional reviver function, and returns
                      // a JavaScript value if the text is a valid JSON text.
                      
                      
                      Severity: Minor
                      Found in lib/assets/javascripts/lib/native.history.js - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language