igor-alexandrov/wiselinks

View on GitHub

Showing 73 of 73 total issues

Function onHashChange has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            History.onHashChange = function(event){
                //History.debug('History.onHashChange', arguments);

                // Prepare
                var currentUrl = ((event && event.newURL) || History.getLocationHref()),
Severity: Minor
Found in build/wiselinks-1.2.2.js - About 1 hr to fix

    Function onHashChange has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                History.onHashChange = function(event){
                    //History.debug('History.onHashChange', arguments);
    
                    // Prepare
                    var currentUrl = ((event && event.newURL) || History.getLocationHref()),
    Severity: Minor
    Found in lib/assets/javascripts/lib/native.history.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

              if (History.options.html4Mode) {
                  History.emulated = {
                      pushState : true,
                      hashChange: true
                  };
      Severity: Critical
      Found in lib/assets/javascripts/lib/native.history.js - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

                if (History.options.html4Mode) {
                    History.emulated = {
                        pushState : true,
                        hashChange: true
                    };
        Severity: Critical
        Found in build/wiselinks-1.2.2.js - About 1 hr to fix

          Function replaceState has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      History.replaceState = function(data,title,url,queue){
                          //History.debug('History.replaceState: called', arguments);
          
                          // We assume that the URL passed in is URI-encoded, but this makes
                          // sure that it's fully URI encoded; any '%'s that are encoded are
          Severity: Minor
          Found in lib/assets/javascripts/lib/native.history.js - About 1 hr to fix

            Function replaceState has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                        History.replaceState = function(data,title,url,queue){
                            //History.debug('History.replaceState: called', arguments);
            
                            // We assume that the URL passed in is URI-encoded, but this makes
                            // sure that it's fully URI encoded; any '%'s that are encoded are
            Severity: Minor
            Found in build/wiselinks-1.2.2.js - About 1 hr to fix

              Function _parser_factory has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  DOMParser.prototype._parser_factory = function() {
                    var create_document_using_DOM, create_document_using_parser, create_document_using_write, e, testDoc, _ref;
                    create_document_using_parser = function(html) {
                      return (new DOMParser).parseFromString(html, 'text/html');
                    };
              Severity: Minor
              Found in build/wiselinks-1.2.2.js - About 1 hr to fix

                Function normalizeState has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        History.normalizeState = function(oldState){
                            // Variables
                            var newState, dataNotEmpty;
                
                            // Prepare
                Severity: Minor
                Found in build/wiselinks-1.2.2.js - About 1 hr to fix

                  Function normalizeState has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          History.normalizeState = function(oldState){
                              // Variables
                              var newState, dataNotEmpty;
                  
                              // Prepare
                  Severity: Minor
                  Found in lib/assets/javascripts/lib/native.history.js - About 1 hr to fix

                    Function checkerFunction has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                                        History.checkerFunction = function(){
                                            // Check Running
                                            if ( checkerRunning ) {
                                                return false;
                                            }
                    Severity: Minor
                    Found in build/wiselinks-1.2.2.js - About 1 hr to fix

                      Function checkerFunction has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                                          History.checkerFunction = function(){
                                              // Check Running
                                              if ( checkerRunning ) {
                                                  return false;
                                              }
                      Severity: Minor
                      Found in lib/assets/javascripts/lib/native.history.js - About 1 hr to fix

                        Method render_with_wiselinks has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def render_with_wiselinks(*args, &block)
                              options = _normalize_args(*args)
                        
                              if self.request.wiselinks?
                                self.headers['Cache-Control'] = 'no-cache, no-store, max-age=0, must-revalidate'
                        Severity: Minor
                        Found in lib/wiselinks/rendering.rb - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 8 locations. Consider refactoring.
                        Open

                            Response.prototype.description = function() {
                              return this._description != null ? this._description : this._description = this._extract_description();
                            };
                        Severity: Major
                        Found in build/wiselinks-1.2.2.js and 7 other locations - About 1 hr to fix
                        build/wiselinks-1.2.2.js on lines 18..20
                        build/wiselinks-1.2.2.js on lines 514..516
                        build/wiselinks-1.2.2.js on lines 518..520
                        build/wiselinks-1.2.2.js on lines 542..544
                        build/wiselinks-1.2.2.js on lines 554..556
                        build/wiselinks-1.2.2.js on lines 566..568
                        build/wiselinks-1.2.2.js on lines 578..580

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 56.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 8 locations. Consider refactoring.
                        Open

                            Response.prototype.robots = function() {
                              return this._robots != null ? this._robots : this._robots = this._extract_robots();
                            };
                        Severity: Major
                        Found in build/wiselinks-1.2.2.js and 7 other locations - About 1 hr to fix
                        build/wiselinks-1.2.2.js on lines 18..20
                        build/wiselinks-1.2.2.js on lines 514..516
                        build/wiselinks-1.2.2.js on lines 518..520
                        build/wiselinks-1.2.2.js on lines 530..532
                        build/wiselinks-1.2.2.js on lines 542..544
                        build/wiselinks-1.2.2.js on lines 566..568
                        build/wiselinks-1.2.2.js on lines 578..580

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 56.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 8 locations. Consider refactoring.
                        Open

                            Response.prototype.canonical = function() {
                              return this._canonical != null ? this._canonical : this._canonical = this._extract_canonical();
                            };
                        Severity: Major
                        Found in build/wiselinks-1.2.2.js and 7 other locations - About 1 hr to fix
                        build/wiselinks-1.2.2.js on lines 18..20
                        build/wiselinks-1.2.2.js on lines 514..516
                        build/wiselinks-1.2.2.js on lines 518..520
                        build/wiselinks-1.2.2.js on lines 530..532
                        build/wiselinks-1.2.2.js on lines 554..556
                        build/wiselinks-1.2.2.js on lines 566..568
                        build/wiselinks-1.2.2.js on lines 578..580

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 56.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 8 locations. Consider refactoring.
                        Open

                            DOMParser.prototype._get_parser = function() {
                              return this._document_parser != null ? this._document_parser : this._document_parser = this._parser_factory();
                            };
                        Severity: Major
                        Found in build/wiselinks-1.2.2.js and 7 other locations - About 1 hr to fix
                        build/wiselinks-1.2.2.js on lines 514..516
                        build/wiselinks-1.2.2.js on lines 518..520
                        build/wiselinks-1.2.2.js on lines 530..532
                        build/wiselinks-1.2.2.js on lines 542..544
                        build/wiselinks-1.2.2.js on lines 554..556
                        build/wiselinks-1.2.2.js on lines 566..568
                        build/wiselinks-1.2.2.js on lines 578..580

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 56.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 8 locations. Consider refactoring.
                        Open

                            Response.prototype.link_rel_next = function() {
                              return this._link_rel_next != null ? this._link_rel_next : this._link_rel_next = this._extract_link_rel_next();
                            };
                        Severity: Major
                        Found in build/wiselinks-1.2.2.js and 7 other locations - About 1 hr to fix
                        build/wiselinks-1.2.2.js on lines 18..20
                        build/wiselinks-1.2.2.js on lines 514..516
                        build/wiselinks-1.2.2.js on lines 518..520
                        build/wiselinks-1.2.2.js on lines 530..532
                        build/wiselinks-1.2.2.js on lines 542..544
                        build/wiselinks-1.2.2.js on lines 554..556
                        build/wiselinks-1.2.2.js on lines 566..568

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 56.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 8 locations. Consider refactoring.
                        Open

                            Response.prototype.title = function() {
                              return this._title != null ? this._title : this._title = this._extract_title();
                            };
                        Severity: Major
                        Found in build/wiselinks-1.2.2.js and 7 other locations - About 1 hr to fix
                        build/wiselinks-1.2.2.js on lines 18..20
                        build/wiselinks-1.2.2.js on lines 514..516
                        build/wiselinks-1.2.2.js on lines 530..532
                        build/wiselinks-1.2.2.js on lines 542..544
                        build/wiselinks-1.2.2.js on lines 554..556
                        build/wiselinks-1.2.2.js on lines 566..568
                        build/wiselinks-1.2.2.js on lines 578..580

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 56.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 8 locations. Consider refactoring.
                        Open

                            Response.prototype.link_rel_prev = function() {
                              return this._link_rel_prev != null ? this._link_rel_prev : this._link_rel_prev = this._extract_link_rel_prev();
                            };
                        Severity: Major
                        Found in build/wiselinks-1.2.2.js and 7 other locations - About 1 hr to fix
                        build/wiselinks-1.2.2.js on lines 18..20
                        build/wiselinks-1.2.2.js on lines 514..516
                        build/wiselinks-1.2.2.js on lines 518..520
                        build/wiselinks-1.2.2.js on lines 530..532
                        build/wiselinks-1.2.2.js on lines 542..544
                        build/wiselinks-1.2.2.js on lines 554..556
                        build/wiselinks-1.2.2.js on lines 578..580

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 56.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 8 locations. Consider refactoring.
                        Open

                            Response.prototype.content = function() {
                              return this._content != null ? this._content : this._content = this._extract_content();
                            };
                        Severity: Major
                        Found in build/wiselinks-1.2.2.js and 7 other locations - About 1 hr to fix
                        build/wiselinks-1.2.2.js on lines 18..20
                        build/wiselinks-1.2.2.js on lines 518..520
                        build/wiselinks-1.2.2.js on lines 530..532
                        build/wiselinks-1.2.2.js on lines 542..544
                        build/wiselinks-1.2.2.js on lines 554..556
                        build/wiselinks-1.2.2.js on lines 566..568
                        build/wiselinks-1.2.2.js on lines 578..580

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 56.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language