Sign upLogin

iivannov/branchio

View on GitHub
Star

Showing 22 of 22 total issues

Avoid variables with short names like $ex. Configured minimum length is 3.
Open

    private function translateClientException(\Throwable $ex): \Throwable
Severity: Minor
Found in src/Client.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in src/Link.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace Iivannov\Branchio\Support;
Severity: Minor
Found in src/Support/UrlType.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace Iivannov\Branchio\Exceptions;
Severity: Minor
Found in src/Exceptions/BranchioException.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace Iivannov\Branchio;
Severity: Minor
Found in src/Link.php by phpcodesniffer

Missing class import via use statement (line '22', column '24').
Open

            return new \Iivannov\Branchio\Client($key, $secret);
Severity: Minor
Found in src/Integration/Laravel/BranchioServiceProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '47', column '38').
Open

        $this->http = $client ?? new \GuzzleHttp\Client();
Severity: Minor
Found in src/Client.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '20', column '27').
Open

                throw new \InvalidArgumentException('Missing BranchIO key and secret in configuration files');
Severity: Minor
Found in src/Integration/Laravel/BranchioServiceProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid too many return statements within this method.
Open

        return BranchioException::makeFromResponse($ex);
Severity: Major
Found in src/Client.php - About 30 mins to fix

    Missing class import via use statement (line '67', column '27').
    Open

                    throw new \InvalidArgumentException();
    Severity: Minor
    Found in src/Link.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid assigning values to variables in if clauses and the like (line '39', column '17').
    Open

        private static function getOriginalBody(\Throwable $exception)
    {
        $lines = explode(PHP_EOL, $exception->getMessage());

        $json = null;
    Severity: Minor
    Found in src/Exceptions/BranchioException.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid using static access to class '\Iivannov\Branchio\Exceptions\BranchioException' in method 'translateClientException'.
    Open

            return BranchioException::makeFromResponse($ex);
    Severity: Minor
    Found in src/Client.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Inline control structures are not allowed
    Open

                if (!$key || !$secret)
    Severity: Minor
    Found in src/Integration/Laravel/BranchioServiceProvider.php by phpcodesniffer

    Expected 1 space after IF keyword; 0 found
    Open

                if(in_array($property, $ignore)) {
    Severity: Minor
    Found in src/Link.php by phpcodesniffer

    Expected 1 newline at end of file; 0 found
    Open

    }
    Severity: Minor
    Found in src/Link.php by phpcodesniffer

    Expected 1 newline at end of file; 0 found
    Open

    }
    Severity: Minor
    Found in src/Exceptions/BranchioDuplicateLinkException.php by phpcodesniffer

    Expected 1 newline at end of file; 0 found
    Open

    }
    Severity: Minor
    Found in src/Exceptions/BranchioNotFoundException.php by phpcodesniffer

    Expected 1 newline at end of file; 0 found
    Open

    }
    Severity: Minor
    Found in src/Support/UrlType.php by phpcodesniffer

    Expected 1 newline at end of file; 0 found
    Open

    }
    Severity: Minor
    Found in src/Exceptions/BranchioException.php by phpcodesniffer

    Expected 1 newline at end of file; 0 found
    Open

    }
    Severity: Minor
    Found in src/Exceptions/BranchioUnavailableException.php by phpcodesniffer
    Severity
    Category
    Status
    Source
    Language