Sign upLogin

imagecms/ImageCMS

View on GitHub
Star
application/modules/admin_menu/assets/js/admin_menu.js

Summary

Maintainability
F
3 days
Test Coverage

Function drop has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        drop: function (event, ui) {
            var identifier = ui.draggable.attr('identifier');
            var parent = ui.draggable.attr('parent');
            var dragEl = ui.draggable.clone();
Severity: Minor
Found in application/modules/admin_menu/assets/js/admin_menu.js - About 1 hr to fix

Function searchModule has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    searchModule: function (el) {
        var searchText = $(el).val().toLowerCase();
        var modules = $(el).closest('ul').find('a');

        if (event.keyCode != 13) {
Severity: Minor
Found in application/modules/admin_menu/assets/js/admin_menu.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function searchModule has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    searchModule: function (el) {
        var searchText = $(el).val().toLowerCase();
        var modules = $(el).closest('ul').find('a');

        if (event.keyCode != 13) {
Severity: Minor
Found in application/modules/admin_menu/assets/js/admin_menu.js - About 1 hr to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    searchModule: function (el) {
        var searchText = $(el).val().toLowerCase();
        var modules = $(el).closest('ul').find('a');

        if (event.keyCode != 13) {
Severity: Major
Found in application/modules/admin_menu/assets/js/admin_menu.js and 1 other location - About 2 days to fix
application/modules/admin_menu/assets/js/admin_menu_show.js on lines 2..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 377.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                    if ($(this).next().prop('tagName') === 'UL') {

                        data[iF]['subMenu'][iS]['subMenu'] = {};

                        $(this).next().find(' > li').each(function (iT) {
Severity: Major
Found in application/modules/admin_menu/assets/js/admin_menu.js and 1 other location - About 3 hrs to fix
application/modules/admin_menu/assets/js/admin_menu_dev.js on lines 198..205

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    uploadTariffs: function (el) {
        $('#loading').show();
        $.ajax({
            url: '/admin/components/init_window/admin_menu/uploadTariffsMenus',
            type: 'POST',
Severity: Major
Found in application/modules/admin_menu/assets/js/admin_menu.js and 1 other location - About 2 hrs to fix
application/modules/admin_menu/assets/js/admin_menu_dev.js on lines 81..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $(tariffs).each(function () {
            var tariffId = $(this).attr('tariff_id');
            var menuList = $(this).find('> ul > li');

            tariffsMenus[tariffId] = self.prepareItem(menuList);
Severity: Major
Found in application/modules/admin_menu/assets/js/admin_menu.js and 1 other location - About 2 hrs to fix
application/modules/admin_menu/assets/js/admin_menu_dev.js on lines 120..125

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status