Sign upLogin

imagecms/ImageCMS

View on GitHub
Star
application/modules/cmsemail/assets/js/email.js

Summary

Maintainability
D
2 days
Test Coverage

File email.js has 263 lines of code (exceeds 250 allowed). Consider refactoring.
Open

jQuery.fn.extend({
    insertAtCaret: function (myValue) {
        return this.each(function (i) {
            if (document.selection) {
                //For browsers like Internet Explorer
Severity: Minor
Found in application/modules/cmsemail/assets/js/email.js - About 2 hrs to fix

Function mailTest has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function mailTest() {
    var from = $('#from').val();
    var from_email = $('#from_email').val();
    var theme = $('#theme').val();
    var protocol = $('#protocol').val();
Severity: Minor
Found in application/modules/cmsemail/assets/js/email.js - About 1 hr to fix

Function update has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    update: function (curElement, template_id, oldVariable, locale) {
        var closestTr = curElement.closest('tr');
        var variable = closestTr.find('.variableEdit');
        var variableValue = closestTr.find('.variableValueEdit');
Severity: Minor
Found in application/modules/cmsemail/assets/js/email.js - About 1 hr to fix

Function add has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    add: function (curElement, template_id, locale) {
        var variable = curElement.closest('tr').find('.variableEdit');
        var variableValue = curElement.closest('tr').find('.variableValueEdit');

        this.validateVariable(variable.val(), variableValue.val());
Severity: Minor
Found in application/modules/cmsemail/assets/js/email.js - About 1 hr to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

jQuery.fn.extend({
    insertAtCaret: function (myValue) {
        return this.each(function (i) {
            if (document.selection) {
                //For browsers like Internet Explorer
Severity: Major
Found in application/modules/cmsemail/assets/js/email.js and 1 other location - About 1 day to fix
application/modules/mod_seo/assets/js/scripts.js on lines 1..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 302.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status