imagecms/ImageCMS

View on GitHub
application/modules/mod_seo/mod_seo.php

Summary

Maintainability
F
6 days
Test Coverage

Function _buildCategoryMeta has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    public static function _buildCategoryMeta($categoryObj) {

        CI::$APP->load->helper('array_helper');

        $local = MY_Controller::getCurrentLocale();
Severity: Minor
Found in application/modules/mod_seo/mod_seo.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File mod_seo.php has 337 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

use CMSFactory\Events;
use CMSFactory\MetaManipulator\GalleryMetaManipulator;
use CMSFactory\MetaManipulator\MetaManipulator;
Severity: Minor
Found in application/modules/mod_seo/mod_seo.php - About 4 hrs to fix

Method _buildCategoryMeta has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function _buildCategoryMeta($categoryObj) {

        CI::$APP->load->helper('array_helper');

        $local = MY_Controller::getCurrentLocale();
Severity: Major
Found in application/modules/mod_seo/mod_seo.php - About 2 hrs to fix

Method _buildProductsMeta has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function _buildProductsMeta($arg) {

        /* @var $model SProducts */
        $model = $arg['model'];
        $local = MY_Controller::getCurrentLocale();
Severity: Minor
Found in application/modules/mod_seo/mod_seo.php - About 1 hr to fix

Method _buildBrandMeta has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function _buildBrandMeta($arg) {

        $local = MY_Controller::getCurrentLocale();
        /* @var $model SBrands */
        $model = $arg['model'];
Severity: Minor
Found in application/modules/mod_seo/mod_seo.php - About 1 hr to fix

Method _buildPageCategoryMeta has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function _buildPageCategoryMeta($model) {

        $local = MY_Controller::getCurrentLocale();

        CI::$APP->core->setLastModified($model['updated']);
Severity: Minor
Found in application/modules/mod_seo/mod_seo.php - About 1 hr to fix

Method _buildPageMeta has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function _buildPageMeta($model) {

        CI::$APP->core->setLastModified($model['updated']);

        $local = MY_Controller::getCurrentLocale();
Severity: Minor
Found in application/modules/mod_seo/mod_seo.php - About 1 hr to fix

Function _buildProductsMeta has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public static function _buildProductsMeta($arg) {

        /* @var $model SProducts */
        $model = $arg['model'];
        $local = MY_Controller::getCurrentLocale();
Severity: Minor
Found in application/modules/mod_seo/mod_seo.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _buildBrandMeta has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public static function _buildBrandMeta($arg) {

        $local = MY_Controller::getCurrentLocale();
        /* @var $model SBrands */
        $model = $arg['model'];
Severity: Minor
Found in application/modules/mod_seo/mod_seo.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _buildPageMeta has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public static function _buildPageMeta($model) {

        CI::$APP->core->setLastModified($model['updated']);

        $local = MY_Controller::getCurrentLocale();
Severity: Minor
Found in application/modules/mod_seo/mod_seo.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _buildPageCategoryMeta has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public static function _buildPageCategoryMeta($model) {

        $local = MY_Controller::getCurrentLocale();

        CI::$APP->core->setLastModified($model['updated']);
Severity: Minor
Found in application/modules/mod_seo/mod_seo.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ($model->getParentId() > 0) {
            if ($settings['usesubcategoryPattern'] != 1) {
                return FALSE;
            }

Severity: Major
Found in application/modules/mod_seo/mod_seo.php and 1 other location - About 1 day to fix
application/modules/mod_seo/mod_seo.php on lines 161..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 301.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        } else {
            if ($settings['useCategoryPattern'] != 1) {
                return FALSE;
            }

Severity: Major
Found in application/modules/mod_seo/mod_seo.php and 1 other location - About 1 day to fix
application/modules/mod_seo/mod_seo.php on lines 130..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 301.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function _buildGalleryMeta() {

        $local = MY_Controller::getCurrentLocale();
        $settings = CI::$APP->seoexpert_model->getSettings($local);

Severity: Major
Found in application/modules/mod_seo/mod_seo.php and 1 other location - About 3 hrs to fix
application/modules/mod_seo/mod_seo.php on lines 378..396

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 158.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function _buildSearchMeta() {

        $local = MY_Controller::getCurrentLocale();
        $settings = CI::$APP->seoexpert_model->getSettings($local);

Severity: Major
Found in application/modules/mod_seo/mod_seo.php and 1 other location - About 3 hrs to fix
application/modules/mod_seo/mod_seo.php on lines 401..419

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 158.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status