Sign upLogin

imagecms/ImageCMS

View on GitHub
Star
application/modules/star_rating/assets/js/scripts.js

Summary

Maintainability
C
1 day
Test Coverage

Function init has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

                init : function(options) {
                    var settings = $.extend(
                        {
                            width:0,
                            afterClick: function(){
Severity: Major
Found in application/modules/star_rating/assets/js/scripts.js - About 2 hrs to fix

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            $.fn.starRating = function( method ) {
                if (methods[method] ) {
                    return methods[ method ].apply(this, Array.prototype.slice.call(arguments, 1));
                } else if (typeof method === 'object' || ! method ) {
                    return methods.init.apply(this, arguments);
Severity: Major
Found in application/modules/star_rating/assets/js/scripts.js and 3 other locations - About 4 hrs to fix
application/modules/comments/assets/js/comments.js on lines 64..72
application/modules/comments/assets/js/comments.js on lines 134..142
application/modules/sitemap/assets/js/rating.js on lines 71..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 124.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                                        if (e.pageX) {
                                            x = e.pageX;
                                        } else if (e.clientX) {
                                            x = e.clientX + (document.documentElement.scrollLeft || document.body.scrollLeft) - document.documentElement.clientLeft;
Severity: Major
Found in application/modules/star_rating/assets/js/scripts.js and 2 other locations - About 2 hrs to fix
application/modules/comments/assets/js/comments.js on lines 102..107
application/modules/sitemap/assets/js/rating.js on lines 37..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

                                $this.hover(
                                    function(){
                                        $(this).append("<span></span>");
                                    },
                                    function()
Severity: Major
Found in application/modules/star_rating/assets/js/scripts.js and 2 other locations - About 1 hr to fix
application/modules/comments/assets/js/comments.js on lines 87..94
application/modules/sitemap/assets/js/rating.js on lines 20..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status