imanghafoori1/laravel-widgetize

View on GitHub

Showing 55 of 55 total issues

Avoid variables with short names like $M. Configured minimum length is 3.
Open

            $M = config('widgetize.default_cache_lifetime', 0);

Since: PHPMD 0.2

Detects when a field, local, or parameter has a very short name.

Example:

class Something {
      private $q = 15; // VIOLATION - Field
      public static function main( array $as ) { // VIOLATION - Formal
          $r = 20 + $this->q; // VIOLATION - Local
          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
              $r += $this->q;
          }
      }
  }

Source: http://phpmd.org/rules/naming.txt

The property $_viewData is not named in camelCase.
Open

class WidgetRenderer
{
    use SlotRenderer;

    public $html;
Severity: Minor
Found in src/Utils/WidgetRenderer.php by phpmd

Since: PHPMD 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example:

class ClassName {
      protected $property_name;
  }

Source: http://phpmd.org/rules/controversial.txt

The property $_policies is not named in camelCase.
Open

class WidgetRenderer
{
    use SlotRenderer;

    public $html;
Severity: Minor
Found in src/Utils/WidgetRenderer.php by phpmd

Since: PHPMD 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example:

class ClassName {
      protected $property_name;
  }

Source: http://phpmd.org/rules/controversial.txt

The property $_cacheTag is not named in camelCase.
Open

class Cache
{
    /**
     * @var \Imanghafoori\Widgets\Utils\CacheTag
     */
Severity: Minor
Found in src/Utils/Cache.php by phpmd

Since: PHPMD 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example:

class ClassName {
      protected $property_name;
  }

Source: http://phpmd.org/rules/controversial.txt

Avoid variables with short names like $s. Configured minimum length is 3.
Open

    public function makeFromSeconds($s)

Since: PHPMD 0.2

Detects when a field, local, or parameter has a very short name.

Example:

class Something {
      private $q = 15; // VIOLATION - Field
      public static function main( array $as ) { // VIOLATION - Formal
          $r = 20 + $this->q; // VIOLATION - Local
          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
              $r += $this->q;
          }
      }
  }

Source: http://phpmd.org/rules/naming.txt

Avoid variables with short names like $l. Configured minimum length is 3.
Open

        $l = $this->widget->cacheLifeTime->i ?? 0;
Severity: Minor
Found in src/Utils/DebugInfo.php by phpmd

Since: PHPMD 0.2

Detects when a field, local, or parameter has a very short name.

Example:

class Something {
      private $q = 15; // VIOLATION - Field
      public static function main( array $as ) { // VIOLATION - Formal
          $r = 20 + $this->q; // VIOLATION - Local
          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
              $r += $this->q;
          }
      }
  }

Source: http://phpmd.org/rules/naming.txt

Property name "$_policies" should not be prefixed with an underscore to indicate visibility
Open

    private $_policies;
Severity: Minor
Found in src/Utils/WidgetRenderer.php by phpcodesniffer

Property name "$_viewData" should not be prefixed with an underscore to indicate visibility
Open

    private $_viewData;
Severity: Minor
Found in src/Utils/WidgetRenderer.php by phpcodesniffer

Property name "$_cacheTag" should not be prefixed with an underscore to indicate visibility
Open

    private $_cacheTag;
Severity: Minor
Found in src/Utils/Cache.php by phpcodesniffer

Method name "_registerDebugbar" should not be prefixed with an underscore to indicate visibility
Open

    private function _registerDebugbar()

Function normalize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function normalize($widget): void
    {
        if (! property_exists($widget, 'cacheLifeTime')) {
            $M = config('widgetize.default_cache_lifetime', 0);
            $widget->cacheLifeTime = $this->makeFromSeconds($M * 60);
Severity: Minor
Found in src/Utils/Normalizers/CacheNormalizer.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using static access to class '\Illuminate\Support\Str' in method 'generateNewToken'.
Open

        $token = Str::random(7);
Severity: Minor
Found in src/Utils/CacheTag.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\Illuminate\Support\Str' in method 'getTplPath'.
Open

        if (Str::contains($tpl, 'Widgets::')) {
Severity: Minor
Found in src/Utils/DebugInfo.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\App' in method 'makeDataForView'.
Open

                $viewData = \App::call($widget->presenter, [$viewData]);
Severity: Minor
Found in src/Utils/WidgetRenderer.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\App' in method 'callController'.
Open

            $viewData = \App::call($widget->controller, ...$args);
Severity: Minor
Found in src/Utils/WidgetRenderer.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\Illuminate\Support\Facades\Blade' in method 'defineDirectives'.
Open

        Blade::directive('widget', function ($expression) use ($omitParenthesis) {
            $expression = $omitParenthesis ? $expression : "($expression)";

            return "<?php echo app(\\Imanghafoori\\Widgets\\Utils\\WidgetRenderer::class)->renderWidget{$expression}; ?>";
        });
Severity: Minor
Found in src/WidgetsServiceProvider.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\Cache' in method 'getPersistedToken'.
Open

        return \Cache::get('9z10_o6cg_r'.$tag, null);
Severity: Minor
Found in src/Utils/CacheTag.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\Illuminate\Support\Facades\Blade' in method 'defineDirectives'.
Open

        Blade::directive('slotWidget', function ($expression) use ($omitParenthesis) {
            $this->expression = $omitParenthesis ? $expression : "($expression)";
        });
Severity: Minor
Found in src/WidgetsServiceProvider.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\Illuminate\Support\Str' in method 'determineDataMethod'.
Open

            if (! Str::contains($widget->controller, '@')) {

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\Illuminate\Support\Facades\Blade' in method 'defineSlotDirectives'.
Open

        Blade::directive('endSlot', function () {
            $contentKey = '$content';

            return "<?php 
                        $contentKey = ob_get_clean();
Severity: Minor
Found in src/WidgetsServiceProvider.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Severity
Category
Status
Source
Language