imanghafoori1/laravel-widgetize

View on GitHub
src/Utils/Normalizers/ControllerNormalizer.php

Summary

Maintainability
A
0 mins
Test Coverage

Reduce the number of returns of this function 4, down to the maximum allowed 3.
Open

    private function determineDataMethod($widget): array

Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

Noncompliant Code Example

With the default threshold of 3:

function myFunction(){ // Noncompliant as there are 4 return statements
  if (condition1) {
    return true;
  } else {
    if (condition2) {
      return false;
    } else {
      return true;
    }
  }
  return false;
}

Missing class import via use statement (line '50', column '23').
Open

            throw new \InvalidArgumentException("'data' method not found on ".$ctrlClass);

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\Illuminate\Support\Str' in method 'determineDataMethod'.
Open

            if (! Str::contains($widget->controller, '@')) {

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

There are no issues that match your filters.

Category
Status