Sign upLogin

inertia186/drotto

View on GitHub
Star

Showing 31 of 31 total issues

Method vote has a Cognitive Complexity of 190 (exceeds 5 allowed). Consider refactoring.
Open

    def vote(bids)
      result = {}
      
      # Vote stacking is where multiple bids are created for the same post.  Any
      # number of transfers from any number of accounts can bid on the same
Severity: Minor
Found in lib/drotto/chain.rb - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method stream has a Cognitive Complexity of 122 (exceeds 5 allowed). Consider refactoring.
Open

    def stream(max_ops = -1)
      @limit ||= 200
      stream = Radiator::Stream.new(chain_options)
      count = 0
Severity: Minor
Found in lib/drotto/bounce_job.rb - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method vote has 286 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def vote(bids)
      result = {}
      
      # Vote stacking is where multiple bids are created for the same post.  Any
      # number of transfers from any number of accounts can bid on the same
Severity: Major
Found in lib/drotto/chain.rb - About 1 day to fix

    Method perform has a Cognitive Complexity of 64 (exceeds 5 allowed). Consider refactoring.
    Open

        def perform(pretend = false)
      
      if voting_in_progress? && !pretend
        debug "Voting in progress, bounce suspended ..."
        sleep 120
    Severity: Minor
    Found in lib/drotto/bounce_job.rb - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method process_bid has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
    Open

      def process_bid(options = {})
    job = options[:job]
    id = options[:id]
    tx = options[:tx] || job.transfer(id)
    timestamp = options[:timestamp]
    Severity: Minor
    Found in lib/drotto.rb - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method force_bounce! has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

        def force_bounce!(trx_id)
      if trx_id.to_s.size == 0
        warning "Empty transaction id."
        return
      end
    Severity: Minor
    Found in lib/drotto/bounce_job.rb - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File chain.rb has 418 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module DrOtto
  require 'drotto/utils'
  
  VOTE_RECHARGE_PER_DAY = 20.0
  VOTE_RECHARGE_PER_HOUR = VOTE_RECHARGE_PER_DAY / 24
    Severity: Minor
    Found in lib/drotto/chain.rb - About 6 hrs to fix

      File bounce_job.rb has 382 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      module DrOtto
  class BounceJob
    include Chain
    
    VIRTUAL_OP_TRANSACTION_ID = '0000000000000000000000000000000000000000'
      Severity: Minor
      Found in lib/drotto/bounce_job.rb - About 5 hrs to fix

        Method stream has 91 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def stream(max_ops = -1)
      @limit ||= 200
      stream = Radiator::Stream.new(chain_options)
      count = 0
        Severity: Major
        Found in lib/drotto/bounce_job.rb - About 3 hrs to fix

          Method perform has 88 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def perform(options = {})
      unless ['steem', 'golos'].include? chain_options[:chain]
        warning "Usage data not available for #{chain_options[:chain]}.  Showing STEEM usage instead."
      end
          Severity: Major
          Found in lib/drotto/usage_job.rb - About 3 hrs to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            elsif message.to_s =~ /Voting weight is too small, please accumulate more voting power or steem power./
                  error "Failed vote: voting weight too small"
                  break
                elsif message.to_s =~ /Vote weight cannot be 0/
                  error "Failed vote: vote weight cannot be zero."
            Severity: Major
            Found in lib/drotto/chain.rb and 1 other location - About 2 hrs to fix
            lib/drotto/chain.rb on lines 391..424

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 103.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                          elsif message.to_s =~ /Voting weight is too small, please accumulate more voting power or steem power./
                error "Failed vote: voting weight too small"
                break
              elsif message.to_s =~ /Vote weight cannot be 0/
                error "Failed vote: vote weight cannot be zero."
            Severity: Major
            Found in lib/drotto/chain.rb and 1 other location - About 2 hrs to fix
            lib/drotto/chain.rb on lines 328..361

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 103.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method perform has 71 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def perform(pretend = false)
      
      if voting_in_progress? && !pretend
        debug "Voting in progress, bounce suspended ..."
        sleep 120
            Severity: Major
            Found in lib/drotto/bounce_job.rb - About 2 hrs to fix

              Method force_bounce! has 68 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def force_bounce!(trx_id)
      if trx_id.to_s.size == 0
        warning "Empty transaction id."
        return
      end
              Severity: Major
              Found in lib/drotto/bounce_job.rb - About 2 hrs to fix

                Method perform has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                Open

                    def perform(options = {})
      unless ['steem', 'golos'].include? chain_options[:chain]
        warning "Usage data not available for #{chain_options[:chain]}.  Showing STEEM usage instead."
      end
                Severity: Minor
                Found in lib/drotto/usage_job.rb - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method process_bid has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def process_bid(options = {})
    job = options[:job]
    id = options[:id]
    tx = options[:tx] || job.transfer(id)
    timestamp = options[:timestamp]
                Severity: Minor
                Found in lib/drotto.rb - About 2 hrs to fix

                  Method init_transactions has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def init_transactions
      return unless @transactions.nil?
      
      response = nil
                  Severity: Minor
                  Found in lib/drotto/bounce_job.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method find_bids has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def find_bids(offset = BLOCK_OVERLAP)
    block_num = head_block
    time = block_time
    starting_block = block_num - block_span(offset)
    bids = []
                  Severity: Minor
                  Found in lib/drotto.rb - About 1 hr to fix

                    Method find_bids has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def find_bids(offset = BLOCK_OVERLAP)
    block_num = head_block
    time = block_time
    starting_block = block_num - block_span(offset)
    bids = []
                    Severity: Minor
                    Found in lib/drotto.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method join_threads has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def join_threads
    unless @threads.nil?
      loop do
        alive = @threads.map do |thread|
          thread if thread.alive?
                    Severity: Minor
                    Found in lib/drotto.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language