Sign upLogin

influencemapping/whos_got_dirt-server

View on GitHub
Star

Showing 3 of 3 total issues

Method handle_with has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

    def handle_with(mod)
      request_module = WhosGotDirt::Requests.const_get(mod)
      response_module = WhosGotDirt::Responses.const_get(mod)

      if !params.key?('queries')
Severity: Minor
Found in app/server.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handle_with has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def handle_with(mod)
      request_module = WhosGotDirt::Requests.const_get(mod)
      response_module = WhosGotDirt::Responses.const_get(mod)

      if !params.key?('queries')
Severity: Major
Found in app/server.rb - About 3 hrs to fix

    Avoid too many return statements within this method.
    Open

              return error(502, e.message)
    Severity: Major
    Found in app/server.rb - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language