infused/ansel

View on GitHub

Showing 3 of 3 total issues

File character_map.rb has 566 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module ANSEL
  module CharacterMap
    NON_COMBINING = {
      'ERR' => "\xFF\xFD",      # � - REPLACEMENT CHARACTER
      '88' => '',               # NON-SORT BEGIN / START OF STRING
Severity: Major
Found in lib/ansel/character_map.rb - About 1 day to fix

    Method convert has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def convert(string)
          output = ''
          scanner = StringScanner.new(string)
          until scanner.eos?
            byte = scanner.get_byte
    Severity: Minor
    Found in lib/ansel/converter.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method convert has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def convert(string)
          output = ''
          scanner = StringScanner.new(string)
          until scanner.eos?
            byte = scanner.get_byte
    Severity: Minor
    Found in lib/ansel/converter.rb - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language