Showing 24 of 24 total issues

Class Table has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Table
    extend Forwardable
    include Enumerable
    include ::DBF::Schema

Severity: Minor
Found in lib/dbf/table.rb - About 3 hrs to fix

    File table_spec.rb has 302 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'spec_helper'
    
    RSpec.describe DBF::Table do
      let(:dbf_path) { fixture('dbase_83.dbf') }
      let(:memo_path) { fixture('dbase_83.dbt') }
    Severity: Minor
    Found in spec/dbf/table_spec.rb - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          context 'with type F (float)' do
            context 'with 0 length' do
              it 'returns nil' do
                column = DBF::Column.new table, 'ColumnName', 'F', 0, 0
                expect(column.type_cast('')).to be_nil
      Severity: Major
      Found in spec/dbf/column_spec.rb and 1 other location - About 1 hr to fix
      spec/dbf/column_spec.rb on lines 134..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          context 'with type I (integer)' do
            context 'with 0 length' do
              it 'returns nil' do
                column = DBF::Column.new table, 'ColumnName', 'I', 0, 0
                expect(column.type_cast('')).to be_nil
      Severity: Major
      Found in spec/dbf/column_spec.rb and 1 other location - About 1 hr to fix
      spec/dbf/column_spec.rb on lines 91..108

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            context 'with 0 decimals' do
              it 'casts value to Integer' do
                value = '135'
                column = DBF::Column.new table, 'ColumnName', 'N', 3, 0
                expect(column.type_cast(value)).to eq 135
      Severity: Major
      Found in spec/dbf/column_spec.rb and 1 other location - About 1 hr to fix
      spec/dbf/column_spec.rb on lines 76..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            context 'with more than 0 decimals' do
              it 'casts value to Float' do
                value = '13.5'
                column = DBF::Column.new table, 'ColumnName', 'N', 2, 1
                expect(column.type_cast(value)).to eq 13.5
      Severity: Major
      Found in spec/dbf/column_spec.rb and 1 other location - About 1 hr to fix
      spec/dbf/column_spec.rb on lines 62..72

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      RSpec.describe DBF, 'of type 31 (Visual FoxPro with AutoIncrement field)' do
        let(:table) { DBF::Table.new fixture('dbase_31.dbf') }
      
        it_behaves_like 'DBF'
      
      
      Severity: Major
      Found in spec/dbf/file_formats_spec.rb and 6 other locations - About 50 mins to fix
      spec/dbf/file_formats_spec.rb on lines 51..65
      spec/dbf/file_formats_spec.rb on lines 69..83
      spec/dbf/file_formats_spec.rb on lines 127..141
      spec/dbf/file_formats_spec.rb on lines 145..159
      spec/dbf/file_formats_spec.rb on lines 163..177
      spec/dbf/file_formats_spec.rb on lines 181..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      RSpec.describe DBF, 'of type 02 (FoxBase)' do
        let(:table) { DBF::Table.new fixture('dbase_02.dbf') }
      
        it_behaves_like 'DBF'
      
      
      Severity: Major
      Found in spec/dbf/file_formats_spec.rb and 6 other locations - About 50 mins to fix
      spec/dbf/file_formats_spec.rb on lines 69..83
      spec/dbf/file_formats_spec.rb on lines 109..123
      spec/dbf/file_formats_spec.rb on lines 127..141
      spec/dbf/file_formats_spec.rb on lines 145..159
      spec/dbf/file_formats_spec.rb on lines 163..177
      spec/dbf/file_formats_spec.rb on lines 181..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      RSpec.describe DBF, 'of type 8b (dBase IV with memo file)' do
        let(:table) { DBF::Table.new fixture('dbase_8b.dbf') }
      
        it_behaves_like 'DBF'
      
      
      Severity: Major
      Found in spec/dbf/file_formats_spec.rb and 6 other locations - About 50 mins to fix
      spec/dbf/file_formats_spec.rb on lines 51..65
      spec/dbf/file_formats_spec.rb on lines 69..83
      spec/dbf/file_formats_spec.rb on lines 109..123
      spec/dbf/file_formats_spec.rb on lines 127..141
      spec/dbf/file_formats_spec.rb on lines 145..159
      spec/dbf/file_formats_spec.rb on lines 181..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      RSpec.describe DBF, 'of type 8c (unknown)' do
        let(:table) { DBF::Table.new fixture('dbase_8c.dbf') }
      
        it_behaves_like 'DBF'
      
      
      Severity: Major
      Found in spec/dbf/file_formats_spec.rb and 6 other locations - About 50 mins to fix
      spec/dbf/file_formats_spec.rb on lines 51..65
      spec/dbf/file_formats_spec.rb on lines 69..83
      spec/dbf/file_formats_spec.rb on lines 109..123
      spec/dbf/file_formats_spec.rb on lines 127..141
      spec/dbf/file_formats_spec.rb on lines 145..159
      spec/dbf/file_formats_spec.rb on lines 163..177

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      RSpec.describe DBF, 'of type 32 (Visual FoxPro with field type Varchar or Varbinary)' do
        let(:table) { DBF::Table.new fixture('dbase_32.dbf') }
      
        it_behaves_like 'DBF'
      
      
      Severity: Major
      Found in spec/dbf/file_formats_spec.rb and 6 other locations - About 50 mins to fix
      spec/dbf/file_formats_spec.rb on lines 51..65
      spec/dbf/file_formats_spec.rb on lines 69..83
      spec/dbf/file_formats_spec.rb on lines 109..123
      spec/dbf/file_formats_spec.rb on lines 145..159
      spec/dbf/file_formats_spec.rb on lines 163..177
      spec/dbf/file_formats_spec.rb on lines 181..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      RSpec.describe DBF, 'of type 83 (dBase III with memo file)' do
        let(:table) { DBF::Table.new fixture('dbase_83.dbf') }
      
        it_behaves_like 'DBF'
      
      
      Severity: Major
      Found in spec/dbf/file_formats_spec.rb and 6 other locations - About 50 mins to fix
      spec/dbf/file_formats_spec.rb on lines 51..65
      spec/dbf/file_formats_spec.rb on lines 69..83
      spec/dbf/file_formats_spec.rb on lines 109..123
      spec/dbf/file_formats_spec.rb on lines 127..141
      spec/dbf/file_formats_spec.rb on lines 163..177
      spec/dbf/file_formats_spec.rb on lines 181..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      RSpec.describe DBF, 'of type 03 (dBase III without memo file)' do
        let(:table) { DBF::Table.new fixture('dbase_03.dbf') }
      
        it_behaves_like 'DBF'
      
      
      Severity: Major
      Found in spec/dbf/file_formats_spec.rb and 6 other locations - About 50 mins to fix
      spec/dbf/file_formats_spec.rb on lines 51..65
      spec/dbf/file_formats_spec.rb on lines 109..123
      spec/dbf/file_formats_spec.rb on lines 127..141
      spec/dbf/file_formats_spec.rb on lines 145..159
      spec/dbf/file_formats_spec.rb on lines 163..177
      spec/dbf/file_formats_spec.rb on lines 181..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method sequel_schema has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def sequel_schema(table_only = false) # :nodoc:
            s = ''
            s << "Sequel.migration do\n" unless table_only
            s << "  change do\n " unless table_only
            s << "    create_table(:#{name}) do\n"
      Severity: Minor
      Found in lib/dbf/schema.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method open_memo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def open_memo(data, memo = nil) # :nodoc:
            if memo
              meth = memo.is_a?(StringIO) ? :new : :open
              memo_class.send(meth, memo, version)
            elsif !data.is_a?(StringIO)
      Severity: Minor
      Found in lib/dbf/table.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method build_memo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def build_memo(start_block) # :nodoc:
              @data.seek offset(start_block)
      
              memo_type, memo_size, memo_string = @data.read(block_size).unpack('NNa*')
              return nil unless memo_type == 1 && memo_size > 0
      Severity: Minor
      Found in lib/dbf/memo/foxpro.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def initialize(table, name, type, length, decimal)
      Severity: Minor
      Found in lib/dbf/column.rb - About 35 mins to fix

        Method build_columns has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def build_columns # :nodoc:
              safe_seek do
                @data.seek(header_size)
                [].tap do |columns|
                  until end_of_record?
        Severity: Minor
        Found in lib/dbf/table.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method find_all has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def find_all(options) # :nodoc:
              select do |record|
                next unless record && record.match?(options)
        
                yield record if block_given?
        Severity: Minor
        Found in lib/dbf/table.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method extract_dbc_data has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def extract_dbc_data # :nodoc:
                data = {}
                @db.each do |record|
                  next unless record
        
        
        Severity: Minor
        Found in lib/dbf/database/foxpro.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language