Sign upLogin

invadersmustdie/puppet-catalog-test

View on GitHub
Star
lib/puppet-catalog-test/test_runner.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method load_scenario_yaml has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def load_scenario_yaml(yaml_file, filter = nil)
      scenarios = YAML.load_file(yaml_file)

      scenarios.each do |tc_name, facts|
        next if tc_name =~ /^__/
Severity: Minor
Found in lib/puppet-catalog-test/test_runner.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_tests! has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def run_tests!
      @out.puts "[INFO] Using puppet #{@puppet_adapter.version}"

      run_start = Time.now
      proc_count = Parallel.processor_count
Severity: Minor
Found in lib/puppet-catalog-test/test_runner.rb - About 1 hr to fix

    Method run_tests! has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def run_tests!
      @out.puts "[INFO] Using puppet #{@puppet_adapter.version}"

      run_start = Time.now
      proc_count = Parallel.processor_count
    Severity: Minor
    Found in lib/puppet-catalog-test/test_runner.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status