Showing 5 of 5 total issues
Method generate has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring. Open
def generate(chain)
graph = Graphviz::Graph.new
graph.attributes[:ratio] = :auto
dependencies = dependencies_by_name(chain.dependencies)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method generate has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
def generate(chain)
graph = Graphviz::Graph.new
graph.attributes[:ratio] = :auto
dependencies = dependencies_by_name(chain.dependencies)Method expand_dependency has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def expand_dependency(dependency, parent)
# The job of this function is to take a dependency and turn it into 0 or more provisions. The dependency could be a normal fully-qualified name or a wildcard. It's not clear at which point pattern matching should affect dependency resolution, but it seems logical since it depends on the available provisions that it's done here.
# Another benefit is that it introduces a fixed point of reference for expanding dependencies. When the resolver invokes this method, it can be assured that it will return the same result.
if dependency.wildcard?
return expand_wildcard(dependency, parent)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
def initialize
@base_attributes = {
:shape => 'box',
:style => 'filled',
:fillcolor => 'white',Method expand_provision has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def expand_provision(provision, dependency)
provider = provision.provider
# If the provision was an Alias, make sure to resolve the alias first:
if provision.alias?- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"