ipaddress-gem/ipaddress

View on GitHub

Showing 10 of 10 total issues

Class IPv4 has 53 methods (exceeds 20 allowed). Consider refactoring.
Open

  class IPv4
    
    include IPAddress
    include Enumerable  
    include Comparable                  
Severity: Major
Found in lib/ipaddress/ipv4.rb - About 7 hrs to fix

    Class IPv6 has 40 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class IPv6 
        
        include IPAddress
        include Enumerable  
        include Comparable                  
    Severity: Minor
    Found in lib/ipaddress/ipv6.rb - About 5 hrs to fix

      Method compress_address has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

          def compress_address
            str = @groups.map{|i| i.to_s 16}.join ":"
            loop do
              break if str.sub!(/\A0:0:0:0:0:0:0:0\Z/, '::')
              break if str.sub!(/\b0:0:0:0:0:0:0\b/, ':')
      Severity: Minor
      Found in lib/ipaddress/ipv6.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File ipv4.rb has 289 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'ipaddress/prefix'
      
      module IPAddress; 
        # 
        # =Name
      Severity: Minor
      Found in lib/ipaddress/ipv4.rb - About 2 hrs to fix

        Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize(str)
              raise ArgumentError, "Nil IP" unless str
              ip, netmask = str.split("/")
              
              # Check the ip and remove white space
        Severity: Minor
        Found in lib/ipaddress/ipv4.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method mongoize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.mongoize(ipaddress)
            ipaddress = self.parse(ipaddress) unless ipaddress.is_a?(IPAddress)
            if ipaddress.bits.length == ipaddress.prefix
              ipaddress.address
            elsif ipaddress.is_a?(IPAddress::IPv6)
        Severity: Minor
        Found in lib/ipaddress/mongoid.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize(str)
              raise ArgumentError, "Nil IP" unless str
              ip, netmask = str.split("/")
        
              if str =~ /:.+\./
        Severity: Minor
        Found in lib/ipaddress/ipv6.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def last
              case
              when prefix <= 30
                self.class.parse_u32(broadcast_u32-1, @prefix)
              when prefix == 31
        Severity: Minor
        Found in lib/ipaddress/ipv4.rb and 1 other location - About 30 mins to fix
        lib/ipaddress/ipv4.rb on lines 389..396

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def first
              case
              when prefix <= 30
                self.class.parse_u32(network_u32+1, @prefix)
              when prefix == 31
        Severity: Minor
        Found in lib/ipaddress/ipv4.rb and 1 other location - About 30 mins to fix
        lib/ipaddress/ipv4.rb on lines 421..428

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method summarize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def self.summarize(*args)
              # one network? no need to summarize
              return [args.first.network] if args.size == 1
              
              i = 0
        Severity: Minor
        Found in lib/ipaddress/ipv4.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language