Sign upLogin

ischenko/yii2-jsloader-systemjs

View on GitHub
Star
src/SystemJs.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\yii\di\Instance' in method 'init'.
Open

        $this->renderer = Instance::ensure($this->renderer, JsRendererInterface::class);
Severity: Minor
Found in src/SystemJs.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\ischenko\yii2\jsloader\helpers\FileHelper' in method 'registerImportMap'.
Open

        $filePath = FileHelper::normalizePath($filePath);
Severity: Minor
Found in src/SystemJs.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid assigning values to variables in if clauses and the like (line '115', column '14').
Open

    protected function registerImportMap(): void
    {
        if (($importMap = $this->getConfig()->toArray()) === []) {
            return;
        }
Severity: Minor
Found in src/SystemJs.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid using static access to class '\yii\helpers\Json' in method 'registerImportMap'.
Open

        $importMap = Json::encode($importMap, $options);
Severity: Minor
Found in src/SystemJs.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Possibly zero references to public method \ischenko\yii2\jsloader\SystemJs::init()
Open

    public function init()
Severity: Minor
Found in src/SystemJs.php by phan

Possibly zero write references to public property \ischenko\yii2\jsloader\SystemJs->position
Open

    public $position;
Severity: Minor
Found in src/SystemJs.php by phan

Returning type \ischenko\yii2\jsloader\systemjs\Config but getConfig() is declared to return \ischenko\yii2\jsloader\ConfigInterface
Open

        return $this->config;
Severity: Minor
Found in src/SystemJs.php by phan

Possibly zero write references to public property \ischenko\yii2\jsloader\SystemJs->minimal
Open

    public $minimal = false;
Severity: Minor
Found in src/SystemJs.php by phan

Returning type ?int but getPosition() is declared to return int
Open

        return $position;
Severity: Minor
Found in src/SystemJs.php by phan

Possibly zero references to protected method \ischenko\yii2\jsloader\SystemJs::renderJs()
Open

    protected function renderJs(array $expressions): void
Severity: Minor
Found in src/SystemJs.php by phan

Avoid variables with short names like $js. Configured minimum length is 3.
Open

    private function appendJsCode(string $js, JsExpression $expression, int $pos)
Severity: Minor
Found in src/SystemJs.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status