Function prepareModules has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
private function prepareModules(): void
{
$extension = '.js';
foreach ($this->getModules(new NotEmptyFiles(2)) as $module) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid assigning values to variables in if clauses and the like (line '37', column '18'). Open
public function toArray(): array
{
$this->prepareModules();
$importMap = ['imports' => [], 'scopes' => []];- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid using static access to class '\ischenko\yii2\jsloader\helpers\FileHelper' in method 'prepareModules'. Open
$file = FileHelper::removeExtension($file, $extension);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\ischenko\yii2\jsloader\helpers\FileHelper' in method 'prepareModules'. Open
$newModule = FileHelper::normalizePath("{$alias}/{$newModule}", '/');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Possibly zero references to public method \ischenko\yii2\jsloader\systemjs\Config::toArray() Open
public function toArray(): array- Exclude checks
Call with 1 arg(s) to \ischenko\yii2\jsloader\systemjs\Module::__construct() which only takes 0 arg(s) defined at /code/src/systemjs/Module.php:20 Open
$module = new Module($module);- Exclude checks