iterative/dvc

View on GitHub
dvc/command/check_ignore.py

Summary

Maintainability
A
1 hr
Test Coverage

Function _show_results has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def _show_results(self, result):
        if not result.match and not self.args.non_matching:
            return

        if self.args.details:
Severity: Minor
Found in dvc/command/check_ignore.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _interactive_mode has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def _interactive_mode(self):
        ret = 1
        while True:
            try:
                target = input()
Severity: Minor
Found in dvc/command/check_ignore.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

    parser = subparsers.add_parser(
        "check-ignore",
        parents=[parent_parser],
        description=append_doc_link(ADD_HELP, "check-ignore"),
        help=ADD_HELP,
Severity: Major
Found in dvc/command/check_ignore.py and 18 other locations - About 35 mins to fix
dvc/command/add.py on lines 44..49
dvc/command/cache.py on lines 35..40
dvc/command/commit.py on lines 41..46
dvc/command/completion.py on lines 97..102
dvc/command/destroy.py on lines 38..43
dvc/command/gc.py on lines 71..76
dvc/command/get.py on lines 57..62
dvc/command/imp.py on lines 40..45
dvc/command/imp_url.py on lines 40..45
dvc/command/install.py on lines 22..27
dvc/command/move.py on lines 32..37
dvc/command/params.py on lines 49..54
dvc/command/params.py on lines 68..73
dvc/command/remove.py on lines 27..32
dvc/command/repro.py on lines 161..166
dvc/command/root.py on lines 21..26
dvc/command/run.py on lines 60..65
dvc/command/update.py on lines 31..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status