iterative/dvc

View on GitHub
dvc/command/data_sync.py

Summary

Maintainability
D
2 days
Test Coverage

File data_sync.py has 262 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from __future__ import unicode_literals

import argparse
import logging

Severity: Minor
Found in dvc/command/data_sync.py - About 2 hrs to fix

    Function add_parser has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

    def add_parser(subparsers, _parent_parser):
        from dvc.command.status import CmdDataStatus
    
        # Pull
        PULL_HELP = "Pull data files from a DVC remote storage."
    Severity: Minor
    Found in dvc/command/data_sync.py - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      class CmdDataPush(CmdDataBase):
          def run(self):
              try:
                  processed_files_count = self.repo.push(
                      targets=self.args.targets,
      Severity: Major
      Found in dvc/command/data_sync.py and 1 other location - About 6 hrs to fix
      dvc/command/data_sync.py on lines 59..75

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      class CmdDataFetch(CmdDataBase):
          def run(self):
              try:
                  processed_files_count = self.repo.fetch(
                      targets=self.args.targets,
      Severity: Major
      Found in dvc/command/data_sync.py and 1 other location - About 6 hrs to fix
      dvc/command/data_sync.py on lines 40..56

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          fetch_parser = subparsers.add_parser(
              "fetch",
              parents=[shared_parent_parser()],
              description=append_doc_link(FETCH_HELP, "fetch"),
              help=FETCH_HELP,
      Severity: Major
      Found in dvc/command/data_sync.py and 2 other locations - About 45 mins to fix
      dvc/command/data_sync.py on lines 104..109
      dvc/command/data_sync.py on lines 154..159

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          pull_parser = subparsers.add_parser(
              "pull",
              parents=[shared_parent_parser()],
              description=append_doc_link(PULL_HELP, "pull"),
              help=PULL_HELP,
      Severity: Major
      Found in dvc/command/data_sync.py and 2 other locations - About 45 mins to fix
      dvc/command/data_sync.py on lines 154..159
      dvc/command/data_sync.py on lines 197..202

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          push_parser = subparsers.add_parser(
              "push",
              parents=[shared_parent_parser()],
              description=append_doc_link(PUSH_HELP, "push"),
              help=PUSH_HELP,
      Severity: Major
      Found in dvc/command/data_sync.py and 2 other locations - About 45 mins to fix
      dvc/command/data_sync.py on lines 104..109
      dvc/command/data_sync.py on lines 197..202

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status