iterative/dvc

View on GitHub
dvc/commands/update.py

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            self.repo.update(
                targets=self.args.targets,
                rev=self.args.rev,
                recursive=self.args.recursive,
                to_remote=self.args.to_remote,
Severity: Major
Found in dvc/commands/update.py and 1 other location - About 1 hr to fix
dvc/commands/imp.py on lines 15..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

    update_parser = subparsers.add_parser(
        "update",
        parents=[parent_parser],
        description=append_doc_link(UPDATE_HELP, "update"),
        help=UPDATE_HELP,
Severity: Major
Found in dvc/commands/update.py and 24 other locations - About 35 mins to fix
dvc/commands/add.py on lines 45..50
dvc/commands/cache.py on lines 35..40
dvc/commands/check_ignore.py on lines 87..92
dvc/commands/commit.py on lines 42..47
dvc/commands/completion.py on lines 26..31
dvc/commands/destroy.py on lines 39..44
dvc/commands/experiments/apply.py on lines 26..31
dvc/commands/experiments/branch.py on lines 21..26
dvc/commands/freeze.py on lines 36..41
dvc/commands/freeze.py on lines 49..54
dvc/commands/get.py on lines 58..63
dvc/commands/get_url.py on lines 27..32
dvc/commands/imp.py on lines 41..46
dvc/commands/imp_url.py on lines 41..46
dvc/commands/install.py on lines 23..28
dvc/commands/move.py on lines 33..38
dvc/commands/params.py on lines 50..55
dvc/commands/params.py on lines 69..74
dvc/commands/queue/kill.py on lines 21..26
dvc/commands/queue/logs.py on lines 27..32
dvc/commands/queue/stop.py on lines 31..36
dvc/commands/remove.py on lines 28..33
dvc/commands/root.py on lines 22..27
dvc/commands/run.py on lines 61..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status